Skip to content

fix(datetime): guard against empty date format string - #519

Merged
deepin-bot[bot] merged 1 commit into
linuxdeepin:masterfrom
MyLeeJiEun:task-395933
Sep 22, 2026
Merged

deepin-bot[bot] merged 1 commit into
linuxdeepin:masterfrom
MyLeeJiEun:task-395933

Conversation

@MyLeeJiEun

@MyLeeJiEun MyLeeJiEun commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor
  1. Add early return when the format string is empty after stripping the year token
  2. Prevent out-of-bounds access on format.at(0) with an empty format

Log: Avoid potential crash when a short date format becomes empty after year removal
Influence: Prevents dock crash on empty short date format

fix(datetime): 防止短日期格式字符串为空

  1. 在移除年份标记后格式字符串为空时提前返回
  2. 避免空格式串上 format.at(0) 的越界访问

Log: 避免短日期格式移除年份后为空导致的潜在崩溃
PMS: TASK-395933
Influence: 修复空短日期格式可能导致的崩溃

Summary by Sourcery

Bug Fixes:

  • Prevent a potential dock crash when removing the year token leaves the short date format empty.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @MyLeeJiEun, you've used your own review budget of 250,000 diff characters for the last 7 days.

You can request another review in 4 hours and 13 minutes by commenting @sourcery-ai review. Upgrade to get a review now.

@sourcery-ai

sourcery-ai Bot commented Sep 22, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds an early exit for short-date formats that become empty after year removal, preventing the subsequent format.at(0) access from causing a dock crash.

File-Level Changes

Change Details Files
Guard short-date format processing after removing year tokens.
  • Return immediately when the resulting format string is empty.
  • Prevent accessing the first character of an empty format string.
plugins/dde-dock/datetime/regionFormat.cpp

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot

Copy link
Copy Markdown

Hi @MyLeeJiEun. Thanks for your PR.

I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1. Add early return when the format string is empty after stripping the year token
2. Prevent out-of-bounds access on format.at(0) with an empty format

Log: Avoid potential crash when a short date format becomes empty after year removal
Influence: Prevents dock crash on empty short date format

fix(datetime): 防止短日期格式字符串为空

1. 在移除年份标记后格式字符串为空时提前返回
2. 避免空格式串上 format.at(0) 的越界访问

Log: 避免短日期格式移除年份后为空导致的潜在崩溃
PMS: TASK-395933
Influence: 修复空短日期格式可能导致的崩溃
@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mhduiy, MyLeeJiEun

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@MyLeeJiEun

Copy link
Copy Markdown
Contributor Author

/forcemerge

@deepin-bot

deepin-bot Bot commented Sep 22, 2026

Copy link
Copy Markdown

This pr force merged! (status: blocked)

@deepin-bot
deepin-bot Bot merged commit 8017159 into linuxdeepin:master Sep 22, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants