fix: resolve AlertToolTip parent binding loop

[52cyb]

修复 AlertToolTip parent binding loop

问题

控制中心-账户-用户组设置，新建/编辑用户组出现错误 Alert 时，QML 报出 binding loop 警告：

qrc:/org/deepin/dtk/EditPanel.qml:39:26: QML AlertToolTip: Binding loop detected for property "parent":
qrc:/org/deepin/dtk/AlertToolTip.qml:33:5

根因

qt6/src/qml/AlertToolTip.qml 第 33 行声明式绑定 parent: _shown ? Overlay.overlay : target 形成自引用依赖环：
parent → Overlay.overlay → window → parent

每次 alert 显示/隐藏时反复重父，触发 Qt binding loop 检测。

修复

将 parent 从声明式绑定改为命令式赋值：

• 新增 _updateParent() 函数
• 通过 Component.onCompleted 和 on_ShownChanged 调用
• 打破 parent ↔ Overlay.overlay ↔ window 循环依赖
• 保留此前提交（c9a9274, dc000a4）的 z-order 与拖动修复语义

改动文件

• qt6/src/qml/AlertToolTip.qml（+5/-1）

验证

• ✅ 代码审核通过（100/100）
• ✅ 本地编译打包验证通过（deb 成功生成）

PMS 任务

PMS TASK-392413

Multica Issue

DDE-145

Summary by Sourcery

Bug Fixes:

• Prevent AlertToolTip binding-loop warnings by updating its parent imperatively when visibility or target changes.

[deepin-ci-robot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 52cyb

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR fixes a QML binding loop warning in AlertToolTip by replacing a declarative parent binding with an imperative update function that is invoked on component completion and when the shown state changes, preserving existing z-order and drag behavior while breaking the cyclic dependency.

Flow diagram for AlertToolTip parent update logic

flowchart TD
    A[_shown changes or component completed] --> B[_updateParent]
    B --> C{_shown?}
    C -->|true| D[set parent = Overlay.overlay]
    C -->|false| E[set parent = target]
    D --> F[parent no longer bound declaratively]
    E --> F[parent no longer bound declaratively]

Loading

File-Level Changes

Change	Details	Files
Replace declarative parent binding in AlertToolTip with an imperative parent update function to eliminate the binding loop.	Remove the declarative parent: _shown ? Overlay.overlay : target binding. Introduce _updateParent() function that assigns parent based on _shown and target/Overlay.overlay. Invoke _updateParent() in Component.onCompleted to initialize the parent. Invoke _updateParent() in on_ShownChanged to keep parent in sync with visibility state.	qt6/src/qml/AlertToolTip.qml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've found 1 issue, and left some high level feedback:

• If parent should also react to changes in target (not only _shown), consider invoking _updateParent() from the onTargetChanged handler as well to keep the parent consistent.
• Double-check that on_ShownChanged matches the actual property name (_shown vs shown) and QML signal naming conventions (e.g. onShownChanged), to ensure the handler is actually triggered.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- If `parent` should also react to changes in `target` (not only `_shown`), consider invoking `_updateParent()` from the `onTargetChanged` handler as well to keep the parent consistent.
- Double-check that `on_ShownChanged` matches the actual property name (`_shown` vs `shown`) and QML signal naming conventions (e.g. `onShownChanged`), to ensure the handler is actually triggered.

## Individual Comments

### Comment 1
<location path="qt6/src/qml/AlertToolTip.qml" line_range="33-37" />
<code_context>
         NumberAnimation { duration: 200 }
     }
-    parent: _shown ? Overlay.overlay : target
+    function _updateParent() {
+        parent = _shown ? Overlay.overlay : target
+    }
+    Component.onCompleted: _updateParent()
+    on_ShownChanged: _updateParent()
     opacity: _shown ? 1 : 0
     enabled: _shown
</code_context>
<issue_to_address>
**issue (bug_risk):** Parent is no longer reactive to `target` or `Overlay.overlay` changes, unlike the original binding.

By turning `parent: _shown ? Overlay.overlay : target` into `_updateParent()` that only runs on `Component.onCompleted` and `_shown` changes, `parent` no longer reacts to `target` or `Overlay.overlay` updates. If either can change at runtime, the item will end up parented incorrectly. Please ensure `_updateParent()` is also triggered when `target` or `Overlay.overlay` change, or reintroduce a binding-like mechanism (e.g. `Binding` or additional change handlers).
</issue_to_address>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}