fix: treat "None" as an inactive value sentinel - #1573
Merged
Conversation
BSB-LAN's `replaceDisabled` firmware setting decides what is sent for a deactivated numeric parameter. It defaults to "---", but Home Assistant's MQTT platform requires the literal string "None" to mark a sensor unknown (PAYLOAD_NONE); with "---", numeric MQTT sensors keep their last value forever instead of going unknown. BSB-LAN's own BSB_LAN_config.h therefore tells Home Assistant users to set "None", and doing so currently prevents this integration from starting with a float_parsing error on State.current_temperature.value. The two official Home Assistant paths for BSB-LAN thus require incompatible firmware settings; accepting "None" as an inactive sentinel lets one device serve both. Refs #1572 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
liudger
added
the
bugfix
Owner
|
This fix was on my todo list. Thanks @lmichelin |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1573 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 14 14
Lines 1379 1379
Branches 150 150
=========================================
Hits 1379 1379 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
liudger
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1572.
BSB-LAN's
replaceDisabledfirmware setting decides what is sent for a deactivated numeric parameter. It defaults to"---", but Home Assistant's MQTT platform requires the literal string"None"to mark a sensor unknown (PAYLOAD_NONE); with"---", numeric MQTT sensors keep their last value forever. BSB-LAN's config file therefore tells Home Assistant users to set"None"— and doing so currently prevents this integration from starting (float_parsingonState.current_temperature.value).As it stands, the two official HA paths for BSB-LAN need incompatible firmware settings. This adds
"None"to the inactive sentinel set so a single device can serve both, and covers it in the existing parameterized test.I deliberately kept this minimal and did not touch the "keep the raw string on conversion failure" behaviour, since it is explicitly asserted by three tests — see the issue for why I think it is nonetheless unsafe for parameterized
EntityInfo[float]/EntityInfo[int]fields. Happy to follow up separately if you want that changed.Full suite: 475 passed. (
examples/speed_test.pyerrors on collection onmaintoo, unrelated.)