Repository navigation
Conversation
The package ships src for go-to-definition, but `files: ["src"]` also published 77 test files, snapshots and test helpers. The `test` entry in .npmignore had no effect, because npm ignores the root .npmignore when `files` is set. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
This PR bumps
|
lukasIO
enabled auto-merge (squash)
November 20, 2026 12:52
Contributor
size-limit report 📦
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The package ships
srcso that go-to-definition in an IDE opens the TypeScript source. But"files": ["dist", "src"]also publishes every test file, snapshot and test helper undersrc: 77 of the 241 files in the tarball. No consumer uses them. Iffilesis set, npm ignores the root.npmignore. So itstestentry does not help.Change
filesinpackage.jsonnow excludes:src/**/*.test.tssrc/**/__snapshots__src/test(mocks and test setup)src/room/token-source/test-tokens.tsOnly test files import
src/testandtest-tokens.ts, andtsconfig.jsonalready excludes them from the build. The rest ofsrcstays in the package.Verified
npm pack --dry-runandpnpm packboth list 164 files, down from 241. No path matchestestorsnap.distis not built in this checkout, so the check covers only thesrcpart of the tarball.🤖 Generated with Claude Code