Repository navigation
fix(shadcn): keep cn in lib/utils.ts when publishing to livekit/web - #1522
Closed
thomasyuill-livekit wants to merge 1 commit into
Closed
thomasyuill-livekit wants to merge 1 commit into
thomasyuill-livekit wants to merge 1 commit into
Conversation
The public shadcn registry now imports cn from the cn package, so shadcn add rewrote lib/utils.ts and the ui components in the livekit/web checkout, and its build stopped. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
thomasyuill-livekit
requested review from
1egoman and
lukasIO
as code owners
November 20, 2026 15:32
Contributor
size-limit report 📦
|
Contributor
Author
|
Closing. The |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
Do not merge this PR before livekit/web#7381 merges.
pnpm shadcn:publish:livekit-webfails, so no registry update can reach livekit/web. The public shadcn registry now importscnfrom thecnpackage.shadcn add --overwriterewritessrc/lib/utils.tsin the livekit/web checkout toexport { cn } from "cn". It also writesimport { cn } from "cn"into theuicomponents. The livekit/web build adds a class insidetwMerge(clsx(inputs))in that file, and it stops withexpected `twMerge(clsx(inputs))` in lib/utils.ts.Change
publish-livekit-web.tsno longer calls the livekit/webupdatescript, because that script fails between its own steps. It runs the same three steps itself:shadcn add,codegen,format. Betweenshadcn addandcodegen, it does these steps:src/lib/utils.ts.from "cn"import insrcback at@/lib/utils.cndependency frompackage.json, then runspnpm install.Verified
pnpm shadcn:publish:livekit-webwith "n" at the prompt:uifiles.codegenandformatpassed.codegen.utils.ts,package.jsonor the lockfile of the agents-ui package.Not done yet
updatescript so that it works with thecnimport. After that PR merges, this script can callupdateagain.🤖 Generated with Claude Code