Skip to content

feat(deposition): use foreign key constraints and use ORM with transactions and joins in more places - #6989

Draft
anna-parker wants to merge 16 commits into
mainfrom
use_sqlalchemy
Draft

feat(deposition): use foreign key constraints and use ORM with transactions and joins in more places#6989
anna-parker wants to merge 16 commits into
mainfrom
use_sqlalchemy

Conversation

@anna-parker

@anna-parker anna-parker commented Jul 26, 2026

Copy link
Copy Markdown
Contributor
  1. add proper foreign key annotations for all tables!
  2. Reduce number of database calls:
  • do status updates in batches where possible
  • use transactions for syncing state across databases (no more splitting up updates SubmissionTable.StatusAll=SUBMITTED_SAMPLE and SampleTable.Status=SUBMITTED into 2 db calls)
  • use table joins for getting sequence metadata from the SubmissionTable for submissions

PR Checklist

  • All necessary documentation has been adapted.
  • The implemented feature is covered by appropriate, automated tests.
  • Any manual testing that has been done is documented (i.e. what exactly was tested?)

🚀 Preview: Add preview label to enable

@claude claude Bot added the deposition related to ENA/INSDC deposition label Jul 26, 2026
@anna-parker anna-parker changed the title feat: use ORM with transactions and joins in more places feat(deposition): use foreign key constraints and use ORM with transactions and joins in more places Jul 26, 2026
Comment thread ena-submission/src/ena_deposition/create_assembly.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deposition related to ENA/INSDC deposition

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant