toolbar: scroll the leading capsule, not the whole bottom bar - #58
Merged
Merged
Conversation
Splitting scroll-leading's children into a fused capsule plus a pinned
trailing item let the capsule claim the full bottomBar width, pushing
the pinned item (and any leading siblings) off-screen in portrait.
Give the leading children their own scrollCapsule segment — a
ToolbarItem containing ScrollView(.horizontal) { ControlGroup { ... } } —
so overflow scrolls inside the capsule while the flexible spacer and
pinned item keep their space.
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #57: splitting
scroll-leadinginto a fusedControlGroupcapsule + flexible spacer + pinned trailing item let the capsule claim the full.bottomBarwidth in portrait — the pinned item (and clipped leading siblings like the task toggle) were pushed off-screen and unreachable.The leading children now get a dedicated
.scrollCapsulesegment —ToolbarItem { ScrollView(.horizontal, showsIndicators: false) { ControlGroup { children } } }— so overflow scrolls inside the capsule while theToolbarSpacer(.flexible)and pinnedcapsule([last])keep their space at the trailing edge. Non-scroll-leadingtoolbars are untouched.Verified build via
swift build; simulator verification pending (logseq/chat uses this for the outliner editor toolbar's pinned hide-keyboard).Link to Devin session: https://app.devin.ai/sessions/e53865e84cdb4e85aad3d7c5b99ba7c9
Open in Devin Desktop: https://app.devin.ai/desktop/session/e53865e84cdb4e85aad3d7c5b99ba7c9?variant=devin
Requested by: @tiensonqin