Skip to content

docs(AGENTS): prefer Rrbvec over O(n²) List concat patterns #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RCmerci merged 1 commit into from
Sep 27, 2026
Merged

docs(AGENTS): prefer Rrbvec over O(n²) List concat patterns #61

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,4 @@
- MUST NOT modify any dune file during development unless explicitly asked

See `.agents/skills/` for platform-specific development guides and `docs/agent-guide/` for design specifications.
- Avoid O(n²) `List` patterns such as `List.concat` and repeated `List.append` on large sequences; when the project already depends on the `rrbvec` package, use `Rrbvec` vectors instead.

@chatgpt-codex-connector chatgpt-codex-connector Bot Sep 27, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Remove List.concat from the quadratic examples

List.concat traverses each input element once, so ordinary uses such as flattening a list of lists are O(total elements), not O(n²). Labeling it as inherently quadratic creates repository-wide guidance that may cause agents to replace a linear, idiomatic operation unnecessarily; narrow this rule to repeated append/concatenation patterns whose growing left operand actually causes quadratic work.

Useful? React with 👍 / 👎.

Loading