chore: isolate story examples from test-support - #2985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Running story examples enables the gallery's
gpui-kit/test-supportdevelopment dependency. GPUI'sApp::flush_effects()then synchronously draws dirty windows during updates, adding work to interactive execution.Move all eight story examples into standalone
example-*workspace packages that depend on the gallery normally. Their GPUI dependency graphs excludetest-supportandleak-detection. Move fixtures with them, update shared fixture references, and update the documented commands. Editor behavior and story test configuration are preserved.This is a temporary workaround for the reported Linux stuttering, not a fix for GPUI's test-support performance. Why the slowdown is particularly severe on Linux still needs profiling and an upstream investigation; no before/after frame-time measurements or cross-platform performance verification are claimed here.
Break Changes
Launch the migrated examples by package name:
The same convention applies to brush, dock, html, large-text, markdown, and tiles.
How to Test
cargo build -p example-editor -p example-brush -p example-dock -p example-html -p example-large-text -p example-markdown -p example-stream-markdown -p example-tiles.cargo test -p example-markdown: 10 tests.cargo tree -p example-editor -e features -i gpui-pre(substitute each package): notest-supportorleak-detectionfeatures.Interactive Linux scrolling and macOS/Windows performance have not been tested.
Checklist