fix(base): name calendar items for accessibility - #2996
Merged
Conversation
Assign accessible labels alongside the visible labels and use complete ISO dates for day cells. Verify item names in day, month, and year views. Co-authored-by: Codex <codex@openai.com>
feigeCode
pushed a commit
to feigeCode/gpui-component
that referenced
this pull request
Sep 7, 2026
Calendar buttons had no accessible names when a presentation assigned button roles, leaving assistive technology unable to identify dates or month/year choices. Set names alongside the default labels, with full ISO dates for day cells so adjacent-month days remain distinguishable. Presentations can still override names through `aria_label`. Validation: a regression test inspects item accessibility metadata in day, month, and year views. It fails on the previous implementation and passes with the fix. Calendar tests and downstream gpui-omarchy integration tests were also exercised with the patch. Co-authored-by: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calendar buttons had no accessible names when a presentation assigned button roles, leaving assistive technology unable to identify dates or month/year choices. Set names alongside the default labels, with full ISO dates for day cells so adjacent-month days remain distinguishable. Presentations can still override names through
aria_label.Validation: a regression test inspects item accessibility metadata in day, month, and year views. It fails on the previous implementation and passes with the fix. Calendar tests and downstream gpui-omarchy integration tests were also exercised with the patch.