feat: add thin stdlib facade over external LLRT dependencies - #23
Closed
huacnlee wants to merge 3 commits into
Closed
feat: add thin stdlib facade over external LLRT dependencies#23huacnlee wants to merge 3 commits into
huacnlee wants to merge 3 commits into
Conversation
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Codex <codex@openai.com>
Replace vendored sources with a thin facade and verify host-owned JIT compatibility. Keep stdlib Git-only until compatible registry dependencies are available. Co-authored-by: Codex <codex@openai.com>
huacnlee
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
quickjs-jit-stdlibas a thin facade over external LLRTbuffer,crypto,path,url, andzlibcrates. Consumers use one entry point for module definitions, loaders and global initialization. LLRT remains a Git dependency pinned to7b95c82a9b15e7ddfb2778eca4b5a63111e74f51; no LLRT implementation sources are copied into this repository.The facade follows LLRT's
rquickjspackage identity. JIT applications retain their application-owned compatibility crate and root Cargo patch so the host and LLRT share the same quickjs-jit types. No compatibility package is shipped here. RustCrypto and compression features match GPUI Shell's current integration.This package is Git-only (
publish = false). It does not solve crates.io publication: compatible registry dependencies and binding integration are still required. GPUI Shell migration instructions are included; this PR does not modify GPUI Shell.Test Plan
Locally passed on macOS Apple Silicon:
cargo test -p quickjs-jit-stdliband--all-features: four integration tests and one documentation example each.python3 scripts/check-stdlib-jit.py(Python 3.11+): four tests each with default and parallel features in an isolated external JIT host. Checks one JIT binding stack, external LLRT dependency sources, shared runtime types, Buffer/URL, hashing, sync compression, asynchronous Blob/WebCrypto/compression and loader composition.cargo +1.89 check -p quickjs-jit-stdlib.cargo fmt --all --checkandgit diff --check.CI covers Linux, macOS and Windows plus Rust 1.89. Remote results are pending.