Skip to content

Draw temp targets at the BG level they target instead of in the override strip#720

Merged
marionbarker merged 1 commit into
devfrom
fix/temp-target-graph-placement
Jul 23, 2026
Merged

Draw temp targets at the BG level they target instead of in the override strip#720
marionbarker merged 1 commit into
devfrom
fix/temp-target-graph-placement

Conversation

@bjorkert

Copy link
Copy Markdown
Member

The Swift Charts migration put temp target bands in the same strip at the top of the graph as overrides, so the two collided and the band no longer showed which BG level the temp target aims for. Before the migration the band was drawn at the target value, 5 mg/dL above and below it, with no label, and only overrides used the top strip. This restores that behavior. Verified with an override and a temp target active at the same time, on both the main and the small graph.

@marionbarker

Copy link
Copy Markdown
Collaborator

Test

✅ successful test

Reproduce the problem

start an override and temp target on the Trio test phone and confirm they are overlapped in the LoopFollow display with dev branch

Confirm the fix

Build the new version of LoopFollow and confirm the Temp Target is plotted at appropriate glucose levels.
The Override is labeled and in a bar above the glucose range as expected.

Temp Target is plotted at target value, 5 mg/dL above and below it, with no label, and only overrides used the top strip.

@marionbarker marionbarker left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve by code review and test.

@marionbarker
marionbarker merged commit 9093e74 into dev Jul 23, 2026
1 check passed
@marionbarker
marionbarker deleted the fix/temp-target-graph-placement branch July 23, 2026 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants