Repository navigation
fix(explore): bind measurements to the declared execution result #7764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
loopx-agent
merged 10 commits into
loopx-project:main
from
shangzh0:codex/explore-measurement-corrections-20261101
Nov 1, 2026
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
816d832
fix(explore): bind measurements to the executed result
shangzh0 c053027
fix(explore): preserve auditable history after attribution checks
shangzh0 affea65
Merge remote-tracking branch 'origin/main' into codex/explore-measure…
loopx-agent 80b730f
fix(explore): qualify historical recovery and committed replay
loopx-agent 518c892
Merge commit '80b730f7402754c4e223c5ee1c941cb99e05ebb2' into codex/ex…
loopx-agent cdb9baa
fix(explore): recover committed inputs before new-write attribution
loopx-agent b817e74
Merge commit '816a14b1f674736285cd7aa61dc1fb19594c90d2' into codex/ex…
loopx-agent 109b10c
Merge commit 'ce9459985c07e7d61508ed759064c3996064df13' into codex/ex…
loopx-agent c0ce5ea
Merge remote-tracking branch 'origin/main' into codex/explore-committ…
loopx-agent 7c4bf29
fix(explore): preserve measurement quarantine in saved finding reader
loopx-agent File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
31 changes: 31 additions & 0 deletions
31
apps/presentation/dashboard/smoke/explore-finding-diagnostics-smoke.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| import assert from "node:assert/strict"; | ||
| import {fetchExploreResults} from "../src/data/chat"; | ||
|
|
||
| // The saved-finding transport used to strip the backend's quarantine reason. | ||
| // A measured, quarantined and unmeasured finding must remain distinguishable. | ||
| const row = {finding_id: "legacy", finding: "Recorded finding", summary: "Original observation", | ||
| status: "confirmed", node_id: "question", question: "Compare candidates", scope: "Fixed input", | ||
| agent_id: "recorder", evidence_refs: ["result:original"], last_updated_at: "2026-01-01T00:00:00Z", | ||
| linked_todos: []}; | ||
| const measurement = {metric: "quality", value: 8, unit: "points", higher_is_better: true, | ||
| comparison_scope: "validation:fixed", input_revision: "input:v1", evaluation_ref: "method:v1", | ||
| candidate_ref: "candidate:a", evidence_ref: "result:original"}; | ||
| const reason = "measurements must cite the executed candidate's result reference"; | ||
| const previousFetch = globalThis.fetch; | ||
| try { | ||
| globalThis.fetch = async () => new Response(JSON.stringify({ok: true, goal_id: "research", total: 3, | ||
| next_cursor: null, items: [{...row, measurement_error: reason}, | ||
| {...row, finding_id: "measured", measurements: [measurement]}, {...row, finding_id: "unmeasured"}]}), | ||
| {headers: {"Content-Type": "application/json"}}); | ||
| const page = await fetchExploreResults("research"); | ||
| assert.equal(page.items[0]!.measurement_error, reason, "Quarantine reason reaches the existing reader"); | ||
| assert.equal(page.items[0]!.measurements, undefined, "Quarantined quantities stay absent"); | ||
| assert.equal(page.items[0]!.status, "confirmed", "The transport does not rewrite the recorded finding status"); | ||
| assert.equal(page.items[1]!.measurements?.[0]?.value, 8, "Valid quantities retain their value"); | ||
| assert.equal(page.items[1]!.measurement_error, undefined); | ||
| assert.equal(page.items[2]!.measurements, undefined); | ||
| assert.equal(page.items[2]!.measurement_error, undefined, "Unmeasured is not a quarantine error"); | ||
| } finally { | ||
| globalThis.fetch = previousFetch; | ||
| } | ||
| console.log("PASS saved finding measurement diagnostics, valid values and unmeasured parity"); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.