[third_party] Import embedpqc ML-DSA 87 implementation in third party - #30955
Merged
timothytrippel merged 2 commits intoAug 25, 2026
Merged
Conversation
xorptr
force-pushed
the
perso_mldsa_ft_provisioning_add_mldsa87
branch
from
August 7, 2026 06:19
a0f53b1 to
6a3daea
Compare
sasdf
approved these changes
Aug 13, 2026
cfrantz
approved these changes
Aug 13, 2026
nasahlpa
approved these changes
Aug 17, 2026
Contributor
|
@xorptr can you please sign off commit |
siemen11
reviewed
Aug 17, 2026
|
|
||
| #include "sw/device/tests/embedpqc/mldsa_testvectors.h" | ||
|
|
||
| #include <stdint.h> |
Contributor
Contributor
There was a problem hiding this comment.
Yes, it's on the plan. This one is still useful which gives us fast smoke test result.
xorptr
force-pushed
the
perso_mldsa_ft_provisioning_add_mldsa87
branch
from
August 17, 2026 17:51
6a3daea to
4f5e2b4
Compare
Author
xorptr
force-pushed
the
perso_mldsa_ft_provisioning_add_mldsa87
branch
from
August 17, 2026 18:42
4f5e2b4 to
a444f40
Compare
xorptr
force-pushed
the
perso_mldsa_ft_provisioning_add_mldsa87
branch
2 times, most recently
from
August 18, 2026 18:18
6a3daea to
8ff8d7c
Compare
This commit imports ML-DSA 87 tiny implementation from embedpqc into third party. Current plan is to use this library to generate ML-DSA 87 public keys from UDS during ft_personalize. Tested locally by running `//sw/device/tests/embedpqc:mldsa87_tiny_test_sim_qemu_rom_with_fake_keys` target Signed-off-by: Lovepreet Singh <lpsingh@google.com>
…s during testing - Create a new constant that represents stack space allocated to run DICE ML-DSA operations during attestation - When running tests for embedpqc ML-DSA implementations, compare the runtime stack usage against stack space allocated for ML-DSA operations. While this may not be better than a full static analysis, this adds a (perhaps) slightly useful layer of protection against stack overflow during DICE ML-DSA operations Tested by running `//sw/device/tests/embedpqc:mldsa44_tiny_test_sim_qemu_rom_with_fake_keys` and `//sw/device/tests/embedpqc:mldsa87_tiny_test_sim_qemu_rom_with_fake_keys` targets locally Signed-off-by: Lovepreet Singh <lpsingh@google.com>
xorptr
force-pushed
the
perso_mldsa_ft_provisioning_add_mldsa87
branch
2 times, most recently
from
August 24, 2026 22:20
6a3daea to
343bba2
Compare
Author
|
Rebased on latest |
timothytrippel
merged commit Aug 25, 2026
aea6d61
into
lowRISC:earlgrey_1.0.0
69 of 70 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR imports ML-DSA 87 tiny implementation from embedpqc into third party. Current plan is to use this library to generate ML-DSA 87 public keys from UDS during ft_personalize.
This PR also updates ML-DSA simulator tests to check that the runtime stack use during the tests is lower than or same as the stack space assigned for ML-DSA operations in the firmware.
Tested locally by running
//sw/device/tests/embedpqc:mldsa87_tiny_test_sim_qemu_rom_with_fake_keysand//sw/device/tests/embedpqc:mldsa44_tiny_test_sim_qemu_rom_with_fake_keystargetsChanges on top of PR #30954