Repository navigation
Conversation
Bumps the npm_and_yarn group with 3 updates in the / directory: [brace-expansion](https://github.com/juliangruber/brace-expansion), [node-forge](https://github.com/digitalbazaar/forge) and [undici](https://github.com/nodejs/undici). Updates `brace-expansion` from 1.1.16 to 1.1.21 - [Release notes](https://github.com/juliangruber/brace-expansion/releases) - [Commits](juliangruber/brace-expansion@v1.1.16...v1.1.21) Updates `node-forge` from 1.4.0 to 1.4.2 - [Changelog](https://github.com/digitalbazaar/forge/blob/main/CHANGELOG.md) - [Commits](digitalbazaar/forge@v1.4.0...v1.4.2) Updates `undici` from 6.29.0 to 6.29.1 - [Release notes](https://github.com/nodejs/undici/releases) - [Commits](nodejs/undici@v6.29.0...v6.29.1) --- updated-dependencies: - dependency-name: brace-expansion dependency-version: 1.1.21 dependency-type: indirect dependency-group: npm_and_yarn - dependency-name: node-forge dependency-version: 1.4.2 dependency-type: indirect dependency-group: npm_and_yarn - dependency-name: undici dependency-version: 6.29.1 dependency-type: indirect dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps the bundler group with 2 updates in the / directory: [activestorage](https://github.com/rails/rails) and [omniauth](https://github.com/omniauth/omniauth). Updates `activestorage` from 8.1.3 to 8.1.3.1 - [Release notes](https://github.com/rails/rails/releases) - [Changelog](https://github.com/rails/rails/blob/v8.1.4.1/activestorage/CHANGELOG.md) - [Commits](rails/rails@v8.1.3...v8.1.3.1) Updates `omniauth` from 2.1.3 to 2.2.0 - [Release notes](https://github.com/omniauth/omniauth/releases) - [Changelog](https://github.com/omniauth/omniauth/blob/master/CHANGELOG.md) - [Commits](omniauth/omniauth@v2.1.3...v2.2.0) --- updated-dependencies: - dependency-name: activestorage dependency-version: 8.1.3.1 dependency-type: indirect dependency-group: bundler - dependency-name: omniauth dependency-version: 2.2.0 dependency-type: indirect dependency-group: bundler ... Signed-off-by: dependabot[bot] <support@github.com>
…yarn-66dc5f6f9b Bump the npm_and_yarn group across 1 directory with 3 updates
…0b7af Bump the bundler group across 1 directory with 2 updates
Rails 8.1.3.1 aborts boot when ruby-vips loads against libvips older than 8.13. This app only resizes Action Text images, so drop ruby-vips and use MiniMagick. Co-authored-by: rsmoke <rsmoke@umich.edu>
Stop staging boot from aborting on old libvips
There was a problem hiding this comment.
🟡 Changes recommended
MiniMagick with Active Storage 8.1.3.1 exposes attachment analysis to arbitrary server-file writes and, with Disk storage, reads unless dependencies are upgraded or restrictive ImageMagick policy mitigations are applied.
1 open issue
What changed in this PR
This PR updates Ruby and JavaScript dependencies and switches Active Storage image processing to MiniMagick to avoid boot failures caused by incompatible libvips installations.
Changes:
- Upgrade
image_processingto 2.x, add MiniMagick explicitly, and removeruby-vipsandffifrom the bundle. - Configure MiniMagick for Active Storage and add specs checking processor selection and backend availability.
- Update Rails and other Ruby dependencies, plus selected JavaScript dependencies.
| File | Description |
|---|---|
yarn.lock |
Updates brace-expansion, node-forge, and undici. |
spec/config/active_storage_variant_processor_spec.rb |
Checks MiniMagick configuration and absence of ruby-vips. |
Gemfile.lock |
Locks updated Ruby dependencies and removes ruby-vips and ffi. |
Gemfile |
Upgrades image_processing and declares MiniMagick directly. |
config/application.rb |
Selects MiniMagick for Active Storage variants. |
Review effort: Balanced
Lock Rails 8.1.4.1 and mini_magick 5.4.0 so Active Storage applies its shipped ImageMagick policy during attachment analysis. Co-authored-by: rsmoke <rsmoke@umich.edu>
…-52ac Upgrade Rails and MiniMagick for GHSA-f3w6-w445-fwh9
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This pull request updates how image processing is handled in the application to avoid boot failures related to the
ruby-vipsgem and ensure compatibility with Active Storage and Action Text image resizing. The main changes are upgrading theimage_processinggem, explicitly usingmini_magickfor image variants, and adding tests to verify the configuration.Dependency updates and configuration:
image_processingto version 2.x and addedmini_magickas a direct dependency to ensure image resizing works without loadingruby-vips, which can cause boot issues if an old version oflibvipsis present.config.active_storage.variant_processor = :mini_magickinconfig/application.rbto force Active Storage to use MiniMagick for image variants, preventing accidental use ofruby-vips.Testing and verification:
spec/config/active_storage_variant_processor_spec.rbto verify that MiniMagick is used for image processing,ruby-vipsis not bundled or available, and the correct processor is configured.