Skip to content

Bump npm_and_yarn and bundler dependencies across the project - #295

Merged
rsmoke merged 8 commits into
mainfrom
staging
Nov 10, 2026
Merged

rsmoke merged 8 commits into
mainfrom
staging

Conversation

@rsmoke

@rsmoke rsmoke commented Nov 10, 2026

Copy link
Copy Markdown
Member

This pull request updates how image processing is handled in the application to avoid boot failures related to the ruby-vips gem and ensure compatibility with Active Storage and Action Text image resizing. The main changes are upgrading the image_processing gem, explicitly using mini_magick for image variants, and adding tests to verify the configuration.

Dependency updates and configuration:

  • Upgraded image_processing to version 2.x and added mini_magick as a direct dependency to ensure image resizing works without loading ruby-vips, which can cause boot issues if an old version of libvips is present.
  • Set config.active_storage.variant_processor = :mini_magick in config/application.rb to force Active Storage to use MiniMagick for image variants, preventing accidental use of ruby-vips.

Testing and verification:

  • Added a new spec spec/config/active_storage_variant_processor_spec.rb to verify that MiniMagick is used for image processing, ruby-vips is not bundled or available, and the correct processor is configured.

dependabot Bot and others added 6 commits October 28, 2026 18:04
Bumps the npm_and_yarn group with 3 updates in the / directory: [brace-expansion](https://github.com/juliangruber/brace-expansion), [node-forge](https://github.com/digitalbazaar/forge) and [undici](https://github.com/nodejs/undici).


Updates `brace-expansion` from 1.1.16 to 1.1.21
- [Release notes](https://github.com/juliangruber/brace-expansion/releases)
- [Commits](juliangruber/brace-expansion@v1.1.16...v1.1.21)

Updates `node-forge` from 1.4.0 to 1.4.2
- [Changelog](https://github.com/digitalbazaar/forge/blob/main/CHANGELOG.md)
- [Commits](digitalbazaar/forge@v1.4.0...v1.4.2)

Updates `undici` from 6.29.0 to 6.29.1
- [Release notes](https://github.com/nodejs/undici/releases)
- [Commits](nodejs/undici@v6.29.0...v6.29.1)

---
updated-dependencies:
- dependency-name: brace-expansion
  dependency-version: 1.1.21
  dependency-type: indirect
  dependency-group: npm_and_yarn
- dependency-name: node-forge
  dependency-version: 1.4.2
  dependency-type: indirect
  dependency-group: npm_and_yarn
- dependency-name: undici
  dependency-version: 6.29.1
  dependency-type: indirect
  dependency-group: npm_and_yarn
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps the bundler group with 2 updates in the / directory: [activestorage](https://github.com/rails/rails) and [omniauth](https://github.com/omniauth/omniauth).


Updates `activestorage` from 8.1.3 to 8.1.3.1
- [Release notes](https://github.com/rails/rails/releases)
- [Changelog](https://github.com/rails/rails/blob/v8.1.4.1/activestorage/CHANGELOG.md)
- [Commits](rails/rails@v8.1.3...v8.1.3.1)

Updates `omniauth` from 2.1.3 to 2.2.0
- [Release notes](https://github.com/omniauth/omniauth/releases)
- [Changelog](https://github.com/omniauth/omniauth/blob/master/CHANGELOG.md)
- [Commits](omniauth/omniauth@v2.1.3...v2.2.0)

---
updated-dependencies:
- dependency-name: activestorage
  dependency-version: 8.1.3.1
  dependency-type: indirect
  dependency-group: bundler
- dependency-name: omniauth
  dependency-version: 2.2.0
  dependency-type: indirect
  dependency-group: bundler
...

Signed-off-by: dependabot[bot] <support@github.com>
…yarn-66dc5f6f9b

Bump the npm_and_yarn group across 1 directory with 3 updates
…0b7af

Bump the bundler group across 1 directory with 2 updates
Rails 8.1.3.1 aborts boot when ruby-vips loads against libvips older than 8.13.
This app only resizes Action Text images, so drop ruby-vips and use MiniMagick.

Co-authored-by: rsmoke <rsmoke@umich.edu>
Stop staging boot from aborting on old libvips
Copilot AI balanced review requested due to automatic review settings November 10, 2026 16:01

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

MiniMagick with Active Storage 8.1.3.1 exposes attachment analysis to arbitrary server-file writes and, with Disk storage, reads unless dependencies are upgraded or restrictive ImageMagick policy mitigations are applied.

1 open issue
What changed in this PR

This PR updates Ruby and JavaScript dependencies and switches Active Storage image processing to MiniMagick to avoid boot failures caused by incompatible libvips installations.

Changes:

  • Upgrade image_processing to 2.x, add MiniMagick explicitly, and remove ruby-vips and ffi from the bundle.
  • Configure MiniMagick for Active Storage and add specs checking processor selection and backend availability.
  • Update Rails and other Ruby dependencies, plus selected JavaScript dependencies.
File Description
yarn.lock Updates brace-expansion, node-forge, and undici.
spec/​config/​active_storage_variant_processor_spec.rb Checks MiniMagick configuration and absence of ruby-vips.
Gemfile.lock Locks updated Ruby dependencies and removes ruby-vips and ffi.
Gemfile Upgrades image_processing and declares MiniMagick directly.
config/​application.rb Selects MiniMagick for Active Storage variants.

Review effort: Balanced

Comment thread config/application.rb Resolved
Lock Rails 8.1.4.1 and mini_magick 5.4.0 so Active Storage applies
its shipped ImageMagick policy during attachment analysis.

Co-authored-by: rsmoke <rsmoke@umich.edu>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified for the dependency updates and MiniMagick configuration change.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

@rsmoke
rsmoke merged commit a793325 into main Nov 10, 2026
11 checks passed

This branch was successfully deployed

1 active deployment
staging — 82ccb130 Deployed Nov 10, 2026 by hatchbox-io[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants