Skip to content

🧪 add unit tests for sha256 function#22

Open
lsb11 wants to merge 1 commit into
mainfrom
add-sha256-tests-10078211780660741736
Open

🧪 add unit tests for sha256 function#22
lsb11 wants to merge 1 commit into
mainfrom
add-sha256-tests-10078211780660741736

Conversation

@lsb11

@lsb11 lsb11 commented Jul 22, 2026

Copy link
Copy Markdown
Owner

🎯 What: The testing gap addressed
The sha256 utility function in functions/api/submit-gap.js lacked unit tests.

📊 Coverage: What scenarios are now tested

  • Known IP string ("127.0.0.1")
  • Empty string edge case ("")
  • String containing non-ASCII/unicode characters ("hello world 🚀") to test TextEncoder handling.
  • Determinism check (ensures calling sha256 twice with the same input yields the same result).

Result: The improvement in test coverage
The pure string hashing function is now completely tested and verified for stability and correctness. We also added vitest to devDependencies and set up the "test" script in package.json.


PR created automatically by Jules for task 10078211780660741736 started by @lsb11

Co-authored-by: lsb11 <269203137+lsb11@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying stackarchitect2 with  Cloudflare Pages  Cloudflare Pages

Latest commit: 629eb49
Status: ✅  Deploy successful!
Preview URL: https://b7b64316.stackarchitect2.pages.dev
Branch Preview URL: https://add-sha256-tests-10078211780.stackarchitect2.pages.dev

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant