Conversation
XLAQO
force-pushed
the
bundle-id-from-map-key
branch
2 times, most recently
from
September 2, 2026 22:02
fa74564 to
8dc0494
Compare
XLAQO
force-pushed
the
bundle-id-from-map-key
branch
from
September 2, 2026 22:04
8dc0494 to
cb11a57
Compare
XLAQO
changed the title
lucmoreau
requested changes
Sep 3, 2026
lucmoreau
left a comment
lucmoreau
left a comment
Owner
There was a problem hiding this comment.
Thank you for the submission. It would be good to accompany such suggested changes with tests that can be inserted into the build showing that the changes are supporting prov-jsonld compatible with its published schema.
lucmoreau
requested changes
Sep 3, 2026
lucmoreau
left a comment
lucmoreau
left a comment
Owner
There was a problem hiding this comment.
Thank you for the submission.
I did not understand what the proposed change aimed to address. It would be good to accompany such suggested changes with tests that can be inserted into the build showing that the changes are supporting prov-jsonld compatible with its published schema.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bundle whose namespace is empty is serialised without a "prefix" block, its prefixes being declared at document level. On deserialisation the deferred "@id" was resolved against the bundle's own prefixes alone, so the bundle identifier came back with a null namespace. The document namespace is now attached as the bundle namespace's parent before the identifier is resolved.