Added --output-dir option to CLI - #228
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe conversion CLI now accepts an optional ChangesConfigurable conversion output directory
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
tests/test_unittests.py (1)
43-48: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winCover both help-output changes.
The test checks only successful rendering and
--version. Assert that--output-dirappears and that the--encodinghelp block does not show[default: None].🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/test_unittests.py` around lines 43 - 48, Update test_help to assert that the CLI help output includes --output-dir and that the --encoding help section does not contain “[default: None]”, while preserving the existing successful-rendering and --version assertions.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/test_unittests.py`:
- Around line 235-256: Update test_explicit_output_dir to make the
default-output assertion independent of prior tests sharing test_workspace:
snapshot the default directory state before _run_tools, then verify the state is
unchanged afterward while retaining validation of custom-output artifacts.
Alternatively, provide this test with a fresh workspace rather than relying on
shared state.
---
Nitpick comments:
In `@tests/test_unittests.py`:
- Around line 43-48: Update test_help to assert that the CLI help output
includes --output-dir and that the --encoding help section does not contain
“[default: None]”, while preserving the existing successful-rendering and
--version assertions.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 281ba5df-b225-4409-a2cd-a49824b8d85e
📒 Files selected for processing (16)
README.mdtests/test_unittests.pytools/conversion_registry.pytools/main.pytools/modules/exporter.pytools/utils/config.pytools/yolo/yolo26_exporter.pytools/yolo/yolov10_exporter.pytools/yolo/yolov5_exporter.pytools/yolo/yolov6_exporter.pytools/yolo/yolov8_exporter.pytools/yolov6r1/yolov6_r1_exporter.pytools/yolov6r3/gold_yolo_exporter.pytools/yolov6r3/yolov6_r3_exporter.pytools/yolov7/yolov7_exporter.pytools/yolox/yolox_exporter.py
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
Test Results 6 files 6 suites 14m 53s ⏱️ Results for commit b4f2105. ♻️ This comment has been updated with latest results. |
rolandocortez
left a comment
rolandocortez
left a comment
There was a problem hiding this comment.
Tested locally on Ubuntu with YOLOv8. --output-dir writes the ONNX and NNArchive to the custom path and leaves the default shared_with_container/outputs untouched. --help also works as expected. LGTM 👍
2 participants
Purpose
shared_with_containeSpecification
None / not applicable
Dependencies & Potential Impact
None / not applicable
Deployment Plan
None / not applicable
Testing & Validation
None / not applicable
AI Usage
Assisted-by: AGENT_NAME:MODEL_VERSION [TOOL1] [TOOL2]
Submitted code was reviewed by a human: YES/NO
The author is taking the responsibility for the contribution: YES/NO
Summary by CodeRabbit
New Features
--output-dirCLI option for storing generated conversion artifacts in a custom location.Tests