Skip to content

fix(runtime): let ACP identities take turns — on-stage gating and progress-note cap - #81

Merged
lvndry merged 2 commits into
mainfrom
fix/acp-runtime-on-stage
Sep 19, 2026
Merged

lvndry merged 2 commits into
mainfrom
fix/acp-runtime-on-stage

Conversation

@lvndry

@lvndry lvndry commented Sep 19, 2026

Copy link
Copy Markdown
Owner

What & why

ACP runtimes (Claude, Codex) were usable to connect but not to actually run a room. Two gaps:

  • The Rooms invite banner and its Go button treated an ACP identity as "nobody on stage" — so no invites could be sent — because that check only understands the Jazz roster. For ACP the runtime is the agent and is always on stage; the check now knows that.
  • Every progress heartbeat was rejected by the hub (frame "progress" is malformed ... note: Too big). ACP adapters name a tool with a full title — for Codex, a whole command line — which overran the 200-char note cap, so the room saw no tool activity and turns looked stalled (and toolless).

How to verify

  • Connect an ACP identity (--runtime claude / --runtime codex), open the app: no "No agent is on stage" banner, invite Go is enabled.
  • Start a room and send a turn that uses tools; confirm tool names stream as progress with no frame "progress" is malformed errors in the hub log, even for long Codex command lines (the note truncates with …).
  • Regression: a Jazz identity with no agent selected still shows "nobody on stage" and still blocks invites.

Verified working against a live test hub.

🤖 Generated with Claude Code

The Rooms invite banner and its Go button gate on `myAgentId`, which only a
Jazz roster ever sets. An ACP identity has no roster, so it read as "nobody on
stage" — no invites could be sent — even though the runtime is the agent and the
bridge already treats it as on stage. Gate on the runtime kind too.
…e frame

ACP adapters name a tool with a full title — for Codex, a whole command line —
which ran past the 200-char `progress.note` cap, so the hub rejected every
progress frame and the turn looked stalled. Raise the cap to 1000 for real tool
names and clamp at the sender, so an over-long note is truncated rather than
dropping the heartbeat it rides on.
@vercel

vercel Bot commented Sep 19, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
quartet Ready Ready Preview Sep 19, 2026 8:01am UTC

@lvndry
lvndry merged commit 6476c6f into main Sep 19, 2026
5 checks passed
@lvndry
lvndry deleted the fix/acp-runtime-on-stage branch September 19, 2026 08:09

This branch was successfully deployed

1 active deployment
Preview — 263ec1fb Deployed Sep 19, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant