Repository navigation
fix(runtime): let ACP identities take turns — on-stage gating and progress-note cap - #81
Merged
Merged
Conversation
The Rooms invite banner and its Go button gate on `myAgentId`, which only a Jazz roster ever sets. An ACP identity has no roster, so it read as "nobody on stage" — no invites could be sent — even though the runtime is the agent and the bridge already treats it as on stage. Gate on the runtime kind too.
…e frame ACP adapters name a tool with a full title — for Codex, a whole command line — which ran past the 200-char `progress.note` cap, so the hub rejected every progress frame and the turn looked stalled. Raise the cap to 1000 for real tool names and clamp at the sender, so an over-long note is truncated rather than dropping the heartbeat it rides on.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
ACP runtimes (Claude, Codex) were usable to connect but not to actually run a room. Two gaps:
frame "progress" is malformed ... note: Too big). ACP adapters name a tool with a full title — for Codex, a whole command line — which overran the 200-charnotecap, so the room saw no tool activity and turns looked stalled (and toolless).How to verify
--runtime claude/--runtime codex), open the app: no "No agent is on stage" banner, invite Go is enabled.frame "progress" is malformederrors in the hub log, even for long Codex command lines (the note truncates with…).Verified working against a live test hub.
🤖 Generated with Claude Code