Repository navigation
feat(runtime): a single, user-extensible runtime catalog - #83
Merged
Merged
Conversation
The four places that had to agree on the preset list — the config type union, the ACP_PRESETS record, the wizard's CHOICES, and the hand-written error string — collapse into one catalog in runtime-catalog.ts, so adding a built-in is a single entry. A machine can register its own agents in ~/.quartet/runtimes.json (name → command/args/label/installHint); they appear in the wizard, answer to --runtime <name>, and carry an install hint, with built-in and reserved names protected. An agent that does not speak ACP still needs its own TurnRunner; this is only about the ACP shortcuts.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
lvndry
added a commit
that referenced
this pull request
Sep 19, 2026
…tet (#82) * feat(runtime): discover and set ACP session config options An ACP agent advertises its session config options — model, reasoning level, mode — on session/new, and takes session/set_config_option to change them. The ACP runtime now captures those options, reapplies the operator's saved choices to every session (a fresh session starts at the agent's defaults), tracks config_option_update the agent pushes on its own, and exposes a setter. Choices persist per identity in config.json and are relayed into the bridge snapshot, so a model or effort picked once survives restarts. * feat(app): configure an ACP agent's model and reasoning from the dashboard The runtime view was a read-only note telling you to configure the agent elsewhere. It now renders a selector per option the agent discloses, bound to the live snapshot, and writing a choice back through /api/runtime/config. Options appear once a room exists to read them from; anything the agent does not expose stays configured in the agent, as the footer still says. * feat(runtime): discover ACP config options on demand, without a room The options only exist once a session does, so the runtime screen opened to an empty page telling you to go open a room first. It now asks the bridge to probe — open one throwaway session, read the options (applying saved selections), close it — when the screen is shown, with a loading line while it runs and a retry if the agent could not be reached. * feat(runtime): one runtime catalog, extensible without a rebuild (#83) The four places that had to agree on the preset list — the config type union, the ACP_PRESETS record, the wizard's CHOICES, and the hand-written error string — collapse into one catalog in runtime-catalog.ts, so adding a built-in is a single entry. A machine can register its own agents in ~/.quartet/runtimes.json (name → command/args/label/installHint); they appear in the wizard, answer to --runtime <name>, and carry an install hint, with built-in and reserved names protected. An agent that does not speak ACP still needs its own TurnRunner; this is only about the ACP shortcuts.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Makes Quartet's runtime list easy to extend — both for us and for people running their own agents. Adding a built-in shortcut used to mean editing four places that had to stay in sync (a config type union, the preset catalog, the wizard's list, and a hand-written error string); those now collapse into one catalog, so a built-in is a single entry.
More importantly, a machine can register its own agents in
~/.quartet/runtimes.json— no rebuild. Each entry (name → command/args/label/installHint) shows up in thequartet connectwizard, answers to--runtime <name>, and gets its own "not on PATH" install hint. Built-in and reserved names (jazz,acp, …) can't be shadowed. This is the "plug in your own harness later" ask, as long as the harness speaks ACP; anything that doesn't still needs its ownTurnRunner, which is the intended seam.Any ACP agent already worked via
--runtime acp --runtime-command …; this just gives your own agents the same first-class treatment the built-ins get.How to verify
~/.quartet/runtimes.json,quartet connectlists exactly the built-ins (Jazz, Claude, Codex, Hermes, Pi, Other) — unchanged.{ "amp": { "command": "amp-acp", "args": ["--stdio"], "label": "Amp" } }to~/.quartet/runtimes.json; runquartet connectand confirm Amp appears in the wizard and--runtime ampselects it.!note, and the built-ins still load.--runtime boguserrors with a message listing the available names (built-ins plus your catalog).Stacked on #82. Base that first.
🤖 Generated with Claude Code