Skip to content

Start Review、待提交 review 和提交 review #31

Closed

Description

@lw396

Parent

#4(PR review 第一版)。界面照抄 VS Code 插件,文字用插件的英文原文;功能范围由 ADR 决定(ADR 0007)。

What to build

评论框的 Start Review 在 GitHub 上开始一个待提交 review,之后的行内评论都加进去;在描述页底部写总结,用 Comment / Approve / Request Changes 提交整个 review。

Acceptance criteria

  • 待提交 review 的评论在 diff 里显示为草稿,和已发出的区分开
  • 打开 PR 时已有我的待提交 review(例如在网页上开始的)就接着用,底部按钮提交它
  • 提交后时间线和 diff 立刻更新,侧边栏和同一 PR 的窗格同步
  • 开始、添加、提交有 io 测试;bun run verify 通过

Activity

  1. self-assigned this
    on Nov 8, 2026
  2. lw396 commented on Nov 8, 2026

    @lw396
    OwnerAuthor

    Implemented in local commits 08db311 and 37a6811 (not pushed by this session): Start Review creates/reuses the viewer’s GitHub pending review; subsequent inline comments and replies join it and show Pending; existing pending review summaries are resumed; description-bottom Comment / Approve / Request Changes submits it, with ordinary discussion Comment when no pending review exists. Successful submission updates acknowledged timeline/diff data and announces same-machine reader/sidebar refreshes. Writes are never automatically retried; unsent text survives failures and refreshes.

    Validation: bun run verify passed (319 tests, lint, build, typecheck, both Herdr loading checks, QuickJS smoke); bun run check:built passed; generated output committed. Real API fixtures captured on test PR #35, with no pending fixture review left behind.

    Independent Standards and Spec reviews completed, fixes reviewed again: no remaining blockers. Nonblocking notes include a busy warning that can linger until the next action, transient initial pending-state presentation, and code context appearing after refresh for locally acknowledged timeline comments. Mac visual/interaction validation remains outstanding (Start Review, draft labels, browser-started review/summary resume, submit actions, failures, and cross-pane/sidebar synchronization). Leaving the ticket open pending that validation.

  3. lw396 commented on Nov 8, 2026

    @lw396
    OwnerAuthor

    按用户要求关闭。

    最终提交(以本条为准,替代先前评论中的旧 SHA):

    • c14772f:Start Review、接续当前账号的待提交 review、后续行内评论/回复加入 review,以及 Comment / Approve / Request Changes 提交。
    • ef72e01:提交状态、已确认评论保留、busy 提示及已有总结保留。
    • 31485a2:合并后的运行时/UI 修复:输入状态在 render 外创建;diff 用可视区窗口化在同一节点 snapshot 中构建交互控件,修复空白和行号无反应;讨论按实测高度排版,回复框增加 Cancel。

    验证:最新完整 bun run verify 通过(322 项测试、lint、build、typecheck、Herdr loading check、QuickJS smoke),bun run check:built 通过,生成产物已提交。用户已在 Mac 确认 diff 和评论功能恢复正常;紧凑卡片/Cancel 按截图反馈实现。Start/添加/提交及拒绝/断线不自动重发有 IO 测试,核心窗口化与评论合并有测试。

    此前滚动条遮挡的判断经同文件开关对照被否定:真正原因是 native virtual-list 的行批次使用独立 arena,外层预建交互节点不能跨 arena 复用。保留这一更正,避免以后沿错误方向排查。

    完整跨窗格/侧边栏同步、不同账号网页接续、Approve/Request Changes、断网恢复以及大 diff 拖动/滚动的 Mac 组合验证,仍未在本会话中逐项取得人工证据;先前双轴审查留下的少量布局/性能建议不作为已验证完成项。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions