You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Implemented in local commits 08db311 and 37a6811 (not pushed by this session): Start Review creates/reuses the viewer’s GitHub pending review; subsequent inline comments and replies join it and show Pending; existing pending review summaries are resumed; description-bottom Comment / Approve / Request Changes submits it, with ordinary discussion Comment when no pending review exists. Successful submission updates acknowledged timeline/diff data and announces same-machine reader/sidebar refreshes. Writes are never automatically retried; unsent text survives failures and refreshes.
Validation: bun run verify passed (319 tests, lint, build, typecheck, both Herdr loading checks, QuickJS smoke); bun run check:built passed; generated output committed. Real API fixtures captured on test PR #35, with no pending fixture review left behind.
Independent Standards and Spec reviews completed, fixes reviewed again: no remaining blockers. Nonblocking notes include a busy warning that can linger until the next action, transient initial pending-state presentation, and code context appearing after refresh for locally acknowledged timeline comments. Mac visual/interaction validation remains outstanding (Start Review, draft labels, browser-started review/summary resume, submit actions, failures, and cross-pane/sidebar synchronization). Leaving the ticket open pending that validation.
验证:最新完整 bun run verify 通过(322 项测试、lint、build、typecheck、Herdr loading check、QuickJS smoke),bun run check:built 通过,生成产物已提交。用户已在 Mac 确认 diff 和评论功能恢复正常;紧凑卡片/Cancel 按截图反馈实现。Start/添加/提交及拒绝/断线不自动重发有 IO 测试,核心窗口化与评论合并有测试。
Activity
lw396 commentedon Nov 8, 2026
Implemented in local commits 08db311 and 37a6811 (not pushed by this session): Start Review creates/reuses the viewer’s GitHub pending review; subsequent inline comments and replies join it and show Pending; existing pending review summaries are resumed; description-bottom Comment / Approve / Request Changes submits it, with ordinary discussion Comment when no pending review exists. Successful submission updates acknowledged timeline/diff data and announces same-machine reader/sidebar refreshes. Writes are never automatically retried; unsent text survives failures and refreshes.
Validation: bun run verify passed (319 tests, lint, build, typecheck, both Herdr loading checks, QuickJS smoke); bun run check:built passed; generated output committed. Real API fixtures captured on test PR #35, with no pending fixture review left behind.
Independent Standards and Spec reviews completed, fixes reviewed again: no remaining blockers. Nonblocking notes include a busy warning that can linger until the next action, transient initial pending-state presentation, and code context appearing after refresh for locally acknowledged timeline comments. Mac visual/interaction validation remains outstanding (Start Review, draft labels, browser-started review/summary resume, submit actions, failures, and cross-pane/sidebar synchronization). Leaving the ticket open pending that validation.
feat: support pending PR reviews and submission (#31)
fix: preserve review submission state and show busy actions (#31)
fix: restore interactive PR diffs and compact discussions (#31)
lw396 commentedon Nov 8, 2026
按用户要求关闭。
最终提交(以本条为准,替代先前评论中的旧 SHA):
验证:最新完整 bun run verify 通过(322 项测试、lint、build、typecheck、Herdr loading check、QuickJS smoke),bun run check:built 通过,生成产物已提交。用户已在 Mac 确认 diff 和评论功能恢复正常;紧凑卡片/Cancel 按截图反馈实现。Start/添加/提交及拒绝/断线不自动重发有 IO 测试,核心窗口化与评论合并有测试。
此前滚动条遮挡的判断经同文件开关对照被否定:真正原因是 native virtual-list 的行批次使用独立 arena,外层预建交互节点不能跨 arena 复用。保留这一更正,避免以后沿错误方向排查。
完整跨窗格/侧边栏同步、不同账号网页接续、Approve/Request Changes、断网恢复以及大 diff 拖动/滚动的 Mac 组合验证,仍未在本会话中逐项取得人工证据;先前双轴审查留下的少量布局/性能建议不作为已验证完成项。