Skip to content

描述页的普通评论、关闭和重新打开、Ready for review #32

Closed

Description

@lw396

Parent

#4(PR review 第一版)。界面照抄 VS Code 插件,文字用插件的英文原文;功能范围由 ADR 决定(ADR 0007)。

What to build

描述页底部发普通评论(没有待提交 review 时);关闭和重新打开 PR;把 draft 标为 ready for review。

Acceptance criteria

  • 自己发的评论立刻出现在时间线里;失败时保留内容并显示原因
  • 关闭、重新打开、ready for review 后,侧边栏的分组和同一 PR 的窗格立即更新
  • io 测试(真实 fixture);bun run verify 通过

Activity

  1. self-assigned this
    on Nov 8, 2026
  2. lw396 commented on Nov 8, 2026

    @lw396
    OwnerAuthor

    Implemented in e5bd4f3 and 222afa6 (committed locally, not pushed). Added Close Pull Request / Reopen Pull Request / Ready for Review on the description page, shared refresh of PR groups and readers, and real GitHub write fixtures from test PR #36. Ordinary comments reuse #31: acknowledged timeline insertion and draft/error retention. Test PR #36 restored to closed/draft; temporary fixture branch refs removed.

    Validation: bun run verify passed (346 tests, typecheck, lint, rebuilt bundle, both Herdr loading checks, QuickJS smoke); bun run check:built passed; changed-file LSP checks clean. Independent Standards and Spec reviewers read the generated patch; both initial and follow-up reviews have no blockers. Nonblocking refactoring/coverage notes remain.

    Mac validation still needed: draft → Ready for Review, close/reopen and error display, sidebar/same-PR pane synchronization, and ordinary-comment failure retention. Leaving the ticket open pending app validation.

  3. lw396 commented on Nov 8, 2026

    @lw396
    OwnerAuthor

    按用户要求关闭。实现已整理为两个本地提交:b723bdd(PR 普通评论、关闭/重开、Ready for Review 及视图同步),e89444c(按 VS Code 截图调整底部状态卡片与评论布局,移除弹出菜单,Change method… 原地展开;主按钮 Merge Pull Request,旁边 using method,默认 Create Merge Commit;修正真实字段 allow_merge_commit)。构建产物已提交,尚未推送。

    验证:最终 bun run verify 通过(350 项测试、lint、typecheck、Herdr 两个 mod 加载检查、QuickJS smoke);check:built 通过。独立 Standards/Spec 复审完成,无阻塞发现。用户 Mac 截图用于迭代;最后一轮 using method、三种合并方式和完整写入/跨窗格同步组合仍未逐项取得人工验证。

    已知非阻塞边界:非管理员账号可能无法通过 REST 读取仓库合并方式设置,当前会误报未启用方式;本票未扩展处理。Checkout 仍属 #8,不在本票范围。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions