Conversation
fivetime
force-pushed
the
upstream/idmap-overlap-20260915
branch
from
September 15, 2026 02:59
4d13202 to
01ee062
Compare
Signed-off-by: Simon Zhou <jp.zdm2008@gmail.com>
Signed-off-by: Simon Zhou <jp.zdm2008@gmail.com>
Signed-off-by: Simon Zhou <jp.zdm2008@gmail.com>
fivetime
force-pushed
the
upstream/idmap-overlap-20260915
branch
from
September 18, 2026 16:17
01ee062 to
6ad4ad4
Compare
fivetime
marked this pull request as ready for review
September 18, 2026 16:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selecting
security.idmap.basecurrently bypasses checks against other isolated containers. Reject fixed ranges that overlap another isolated container on the same server, while allowing the owning instance to retain its range and snapshots to inherit it.This changes existing behavior: two isolated containers can no longer intentionally share a fixed range through this path. The documentation explains how to select a different base or use automatic allocation when copying a container. This checks configured allocation ranges; it does not redefine
raw.idmapor introduce cross-server coordination.Rebased onto current upstream main, retaining the allocation locking introduced by #3999 and the exact-gap regression from #3998. The system test covers conflicting creation and update requests, retaining the owner's range, snapshots, and copying with a different fixed base.
The previous amd64 and arm64
dirsystem jobs both failed because the test usedincus delete idmap1/fixed-idmap. Snapshot creation and the preceding overlap checks had succeeded. This now usesincus snapshot delete idmap1 fixed-idmap.Validation: Linux
go test -v ./...andmake static-analysispass. The full system matrix remains subject to the new upstream CI run; it is not claimed as locally passed.The contributor's existing DCO sign-offs are preserved on all three commits.