Skip to content

fix(quality): reject incomplete release evidence and approvals - #95

Merged
ma2za merged 5 commits into
ma2za:mainfrom
mazzasaverio:fix/quality-gate-required-evidence
Oct 11, 2026
Merged

ma2za merged 5 commits into
ma2za:mainfrom
mazzasaverio:fix/quality-gate-required-evidence

Conversation

@mazzasaverio

@mazzasaverio mazzasaverio commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

The quality gate returned SHIP with absent external evaluation, a missing critical entity or infinite external F1. Reject incomplete/invalid evidence, compare critical annotation support and report which entities actually have observations. The release verifier now requires all five criteria to pass explicitly and rejects legacy skipped external evaluations. Count-based F1 avoids division by zero for zero-TP entities.

Validation: three tests reproduced false approval; 40 focused tests passed after correction. Full CI passed 545 tests per matrix job with 95.00% to 95.06% coverage, plus quality, docs, performance, property, packaging and installed-wheel checks: https://github.com/ma2za/pseudonymize/actions/runs/36973630305 . Detector behavior and quality tolerances are unchanged. Reconciling the roadmap's stricter exact-boundary improvement protocol remains separate work, explicitly documented here.

Current review status

Review priority: 2 of 9; PR #100 is the packaging prerequisite. Updated against main 17e8fcc while preserving development version 1.37.0 and the hosted-service changes. Includes the shared service-extra audit correction from #100. No PR has been merged.

Current branch validation: 41 focused tests passed; Ruff formatting/lint, mypy, wheel/sdist builds and release verification passed. Fresh CI on the current head completed with 18 successful checks, one skipped check, and no failures.

ma2za added 4 commits October 9, 2026 11:52
# Conflicts:
#	CHANGELOG.md
#	tests/integration/test_release_verifier.py
# Conflicts:
#	CHANGELOG.md
#	tests/integration/test_release_verifier.py
@ma2za
ma2za merged commit b0edb97 into ma2za:main Oct 11, 2026
3 checks passed
ma2za added a commit that referenced this pull request Oct 11, 2026
The roadmap mixes historical release inventory with current priorities
and names extras that are not declared by the package. Add a
source-backed product review, link it from VISION/ROADMAP and
documentation navigation, and align the current extra list with
pyproject.toml.

The review connects five implemented PRs (#91 through #95) to their
product value, then prioritizes remaining contract, resource,
integration and measurement work with explicit acceptance conditions. It
retains the local-first dependency-free vision and distinguishes
source-grounded privacy proposals from dynamically validated findings.
It makes no new model-quality, certification or release-publication
claim.

Validation: pre-commit, strict mypy, strict docs build, package build,
release verifier and git diff --check passed. Full CI, including the
Linux/Windows test matrix, property tests and installed-wheel checks,
passed: https://github.com/ma2za/pseudonymize/actions/runs/36974122837 .
Documentation and performance workflows also passed. The additional
isolated privacy harness could not start because namespace setup was
denied, which is recorded as a validation limit. No production service
was probed or changed.


### Current review status

Review priority: 7 of 9; PR #100 is the packaging prerequisite. Updated
against main `17e8fcc` while preserving development version 1.37.0 and
the hosted-service changes. Includes the shared service-extra audit
correction from #100. No PR has been merged.

Current branch validation: 11 focused tests passed; Ruff
formatting/lint, mypy, wheel/sdist builds and release verification
passed. Strict documentation build passed. Fresh CI on the current head
completed with 18 successful checks, one skipped check, and no failures.

---------

Co-authored-by: Paolo Mazza <mazzapaolo2019@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants