Skip to content

fix: fix security issue in runner.js #1506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
anupamme wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

fix: fix security issue in runner.js #1506

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be0b915
fix: V-001 security vulnerability
anupamme Sep 16, 2026
83b2816
Merge branch 'master' into fix-repo-analyze-css-ssrf-url-validation
macbre Sep 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions lib/runner.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,22 @@ function runner(options, callback) {
if (options.url) {
debug("Fetching remote CSS file: %s", options.url);

// block SSRF: only allow http(s) URLs and reject localhost / private / link-local addresses
var parsedUrl = new (require("url").URL)(options.url);
var blockedHostname =
/^(localhost|127\.|10\.|172\.(1[6-9]|2\d|3[01])\.|192\.168\.|169\.254\.|0\.0\.0\.0|::1)/;

if (
!/^https?:$/.test(parsedUrl.protocol) ||
blockedHostname.test(parsedUrl.hostname)
) {
var urlErr = new Error(
"Fetching from this URL is not allowed: " + options.url,
);
urlErr.code = analyzer.EXIT_URL_LOADING_FAILED;
return callback(urlErr);
}

// @see https://www.npmjs.com/package/node-fetch#options
var agentOptions = {},
requestOptions = {
Expand Down