Repository navigation
revert(traefik): defer the http to https redirect to the cloudflare edge - #324
Closed
dargmuesli wants to merge 1 commit into
Closed
dargmuesli wants to merge 1 commit into
dargmuesli wants to merge 1 commit into
Conversation
Reverts #322; its redirect labels sat on the web-only routers that the cloudflare tunnel never reaches, so they redirected nothing. The edge now enforces https.
Member
Author
|
Closing in favor of keeping the http-to-https redirect middleware on the http routers as a fallback. The cloudflare edge already enforces https, so the origin-side labels are belt-and-suspenders rather than load-bearing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts #322, which attached the http-to-https redirect middleware to the http-only routers. In production those routers sit behind the cloudflare tunnel's https entrypoint and are never reached, so the redirect never ran and the labels described an enforcement that was not actually in place. The cloudflare edge now forces https for every hostname, which makes the origin-side labels redundant.
The www-to-apex host canonicalization stays on the secure router, because the edge redirect changes only the scheme and not the host. In development the redirect labels return to being dev-only, where the http entrypoint is still reached directly.