Skip to content

fix: resolve open CodeQL alerts in CI permissions and tests - #23

Merged
ruko1202 merged 2 commits into
mainfrom
fix/codeql-alerts
Oct 16, 2026
Merged

ruko1202 merged 2 commits into
mainfrom
fix/codeql-alerts

Conversation

@ruko1202

Copy link
Copy Markdown
Contributor

Resolves the 8 open CodeQL alerts on the Security tab: five missing GITHUB_TOKEN permission blocks in the CI workflow, and three escaping findings in test code.

Not in this PR: secret scanning and push protection are disabled on the repository. That is a repo setting to enable, not a code change. The Dependabot alerts are already closed: vitest was fixed by #22, and braces was auto-dismissed because it is dev-only and has no patched version.

🤖 Generated with Claude Code

ruko1202 and others added 2 commits October 16, 2026 12:00
Closes CodeQL actions/missing-workflow-permissions (#1-#5): the check jobs
inherited the repository's default GITHUB_TOKEN scope. The image job keeps
its own contents: read + packages: write.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- use-timezone: extract the emitted script with the HTML parser instead of a
  <script> regex plus entity decoding (#6 bad-tag-filter, #7 double-escaping).
  A script body is raw text, so decoding never matched what a browser runs.
- otp-nonce-cookie: compare the cookie name segment directly instead of
  building a RegExp that escaped only dots (#8 incomplete-sanitization).

Both still bite: dropping the script's early return and renaming the deleted
cookie each turn the suite red.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ruko1202
ruko1202 merged commit e0f92be into main Oct 16, 2026
10 checks passed
@ruko1202
ruko1202 deleted the fix/codeql-alerts branch October 16, 2026 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant