Repository navigation
fix: resolve open CodeQL alerts in CI permissions and tests - #23
Merged
Merged
Conversation
- use-timezone: extract the emitted script with the HTML parser instead of a <script> regex plus entity decoding (#6 bad-tag-filter, #7 double-escaping). A script body is raw text, so decoding never matched what a browser runs. - otp-nonce-cookie: compare the cookie name segment directly instead of building a RegExp that escaped only dots (#8 incomplete-sanitization). Both still bite: dropping the script's early return and renaming the deleted cookie each turn the suite red. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the 8 open CodeQL alerts on the Security tab: five missing GITHUB_TOKEN permission blocks in the CI workflow, and three escaping findings in test code.
actions/missing-workflow-permissions): the workflow now setspermissions: contents: readat the top level, so check jobs no longer inherit the repository's default token scope. The image job keeps its owncontents: read+packages: write.use-timezone.test.tsx(feat(auth): move provider sign-in and invitations to the backend dance #6js/bad-tag-filter, feat(integrations): add dev-gated OIDC and GitHub provider forms #7js/double-escaping): the emittedTzInitScriptis extracted with the HTML parser (<template>+querySelector) instead of a<script>regex plus manual entity decoding. A script body is raw text and never entity-decoded, so the parser output is what a browser actually runs.otp-nonce-cookie.test.ts(fix(integrations): realign the registry UI to the (kind, name) contract #8js/incomplete-sanitization): the cookie name segment is compared directly instead of through aRegExpthat escaped only dots.return, or renaming the deleted cookie, still turns the suite red.npm run verifypasses.Not in this PR: secret scanning and push protection are disabled on the repository. That is a repo setting to enable, not a code change. The Dependabot alerts are already closed: vitest was fixed by #22, and braces was auto-dismissed because it is dev-only and has no patched version.
🤖 Generated with Claude Code