Repository navigation
fix: allow admins to use shared Slack buttons and forms - #201
Merged
Merged
Conversation
Signed-off-by: Tiberiu Socaci <tsocaci@makeitfuture.com>
Signed-off-by: Tiberiu Socaci <tsocaci@makeitfuture.com>
Signed-off-by: Tiberiu Socaci <tsocaci@makeitfuture.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Admins clicking another requester's Settings or Variables button were rejected, while Files already allowed an admin override. Apply the same current-admin authorization to shared menu controls, legacy menu Resume, question forms, busy-thread decisions and engine-switch/retry cards.
Menu views belong to the clicking admin, including personal settings and credentials. Question and run-decision continuations retain the original requester's author, credentials and runtime lane, with the responding admin recorded in audit. Membership, channel authorization, revision checks and single submission remain enforced; automatic cross-author steering protection is unchanged.
Validation: full coverage suite passed (4,025 tests passed, 34 skipped, zero failures; lines 94.30%, branches 86.65%, functions 90.28%). Static, secret scan, security coverage and signed-off commit checks passed. Added regression tests for admin/ordinary-member behavior, personal scope isolation, requester identity, demotion, membership revocation, stale views and replay. FEATURES.md, TEST-PLAN.md and CHANGELOG.md are updated. Private QA definitions are updated; live Slack acceptance remains unexecuted.