Repository navigation
fix(ci): retry the install that checks the published wheel - #85
Merged
Merged
Conversation
On apkradar 2026.48 the wait saw the version at 15:04:30 and the single install three seconds later, on the same runner, was told it did not exist; the release was fine. The same single install is here. It now goes through .github/scripts/install_from_pypi.sh, which asks again (10 x 30 s) until it succeeds or names the version, the same script and test in all six Radar. The disproved one-resolver test goes; the shared file keeps the no-margin assertion with the right reason. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Merging this PR will not alter performance1 warning
Comparing |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Why
On apkradar 2026.48 (2026-11-16) Publish to PyPI went red on a good release:
wait_for_pypi.shsaw the version at 15:04:30, and the single install that checks the published wheel, three seconds later on the same runner, was toldfrom versions: … 2026.47. releaseradar had lost the same way on v2026.2 and v2026.4 (the second time with a 45 s grace) and retried its install inline since.What this does here
The check made one
pip install --only-binary :all: patchradar==$VERSIONafter the wait; it now installs through the script. The test that claimed one resolver needs no retry is removed; the old "published file is checked" test now requires the script.Shared across the six Radar
.github/scripts/install_from_pypi.sh, byte-identical in all six: retriespip install --no-cache-dir --only-binary :all: <pkg>==<version>(10 × 30 s) and exits 1 naming the version.tests/test_install_from_pypi.py, identical but for the package name: runs the script for real against a fake venv pip (exact wheel, retry, give up, usage, default interval), and checks publish.yml installs through it after the upload, with no barepip installand no grace on any wait.Companion PRs: apkradar#63, and one each in cookieradar, mailradar, patchradar, releaseradar, exeradar.
Verification
--only-binary :all:; a nonexistent version retried and exited 1.🤖 Generated with Claude Code