Repository navigation
Rework the File menu: Open, Save, Save As, Load and slot names - #2274
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
CI status: Generated by Claude Code |
Stand-in review (stand-in-pr-review + /bmad-code-review, lean pass): CONDITIONAL GO at a0f5b60, one patch findingThe code is sound. One governed dashboard tile changes meaning without being updated, so that needs a fix before merge. F1 (patch, Acceptance Auditor): File-key picks feed the menu funnel as if they came through a menu
Fix: give the funnel's pick step a Nits (fold in, no re-review needed)
Checked
Hot-path record (section 6)
Verdict: CONDITIONAL GO, on condition that F1 is fixed (the funnel's pick step excludes Generated by Claude Code |
📸 Screenshot drift checkNo drift: the committed screenshots already match a fresh deterministic generation. ✅ |
|
Review fixes in 9d32772:
The precache budget failure is waiting on the separate budget PR from the release thread (6 MiB per the party); this branch rebases once it lands. The pinned gallery redraw is running. Generated by Claude Code |
Stand-in re-review: GO at 9d32772
The hot-path record from a0f5b60 carries: the change replaces one Generated by Claude Code |
File > Import becomes Open… (Ctrl+O), Quick Save becomes Save (Ctrl+S), Export becomes Save As… (Ctrl+Shift+S) and Saves… becomes Saved Towers…. Cmd works in place of Ctrl on a Mac. The keys leave a text box alone, do nothing over a dialog or after the engine stopped, and on the title screen only Open runs. File > Load is a submenu listing the Auto-save and each saved slot by name, filled each time the File menu opens. A mouse opens it by pointing, a tap toggles it, and the arrow keys walk in and out. On a phone it opens in place under its title. Saved Towers… gains Rename… for each numbered slot. The name is a device preference beside the saves, never in a tower file, and shows in File > Load and the title screen's picker. The dialog's own Save As and Open buttons are gone: the File menu has both. Analytics: the Load items report menu_pick codes load_auto and load_slot_1 to 3, a File key reports its item's menu_pick with via "shortcut", and a slot rename reports app_action rename_slot (named or cleared, never the name). Help pages, issue forms and the data map follow. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ms7traNLWiXFbFoq6kWKFU
…opped engine Close moves to the end of the File menu below its own line, as a program's Exit does (owner). A File key that ran now reports app_action file_key (open, save or save_as) instead of a menu_pick, so the menu funnels and the picks-by-item and what-follows-what tiles count menu trips only (review F1). Open, Save and Save As gray with Close once the engine has stopped, matching the keys, which refuse them then. The kept-unreadable note points at File > Open…. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ms7traNLWiXFbFoq6kWKFU
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
9d32772 to
6607c76
Compare
Saved Towers now shows Rename… on each slot and Close alone in its footer. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ms7traNLWiXFbFoq6kWKFU
Requested by Naftali · project thread
What & why
The File menu reads like a 90s program's, for 4.1 (Naftali, 2026-11-15: rename Import and Export to Open and Save As, rename Saves, reorder the menu, "Full set plus slot names", and "load can be a sub menu that contains the auto and other saves").
.vctowerdownload). Cmd works on a Mac. The Save As dialog's primary reads "Save .vctower".src/game/fileShortcuts.ts): one keydown listener. A text box, text area, list box or editable text keeps its keys (nothing runs, no preventDefault). Elsewhere the press is taken so the browser's Open and Save Page never show over the game; nothing runs over a dialog, after the engine stopped, or on a held key's repeats; on the title screen only Open runs, as the grayed items say. New Tower and Close get no keys (Ctrl+N and Ctrl+W are the browser's).src/game/loadMenu.ts): lists the Auto-save and each readable slot as "Slot 1: Tower One", refilled from the cachedSaveGame.listSlots()each time File opens. At most four rows, so it never scrolls. In a tower it runs the same load as Saved Towers…' Load; on the title screen it runsloadFromSplashand welcomes a founder, as the title picker does.src/ui/menuBar.ts): a mouse opens a submenu by pointing and its click keeps it open; a tap toggles it; Right, Left and Esc walk in and out. On a phone the submenu opens in place under its title (media-phone.css).src/storage/slotLabels.ts,src/ui/slotRename.ts): Saved Towers… gains Rename… on each numbered slot. The name is a device preference in its own key (vc.slotNames), never in a tower file, up to 28 characters; empty gives the number back. It shows in Saved Towers…, File > Load and the title picker (slotName).menu_pickcodesload_autoandload_slot_1toload_slot_3; a File key sends its item'smenu_pickwithvia: "shortcut"andbrowsed: 0; a rename sendsapp_actionrename_slot(namedorcleared, never the name). Existing codes keep their names across the rename (import,export,quick_save,saves). Data map and the dashboard's persistence tile updated.Type of change
Game mode impact
Quality gates
npm run typechecknpm run lintnpm test(the UI, game, storage, analytics and guard suites locally; the full suite runs in CI)npm run build(vite build locally; CI runs the full build)Versioning
.changesnote with the rightapp:andcrate:levels (app: minor,crate: none)Complexity
Nothing runs per frame or per tick. Opening the File menu reads the cached slot list (four rows) and, for a named slot, one
localStorageread compared against the last text read, so a name is parsed only when it changed. A key press does two compares before it knows it is not a File key.Hot-path record (section 6): no hot path is touched. HP-1 per-pass work: none added to a tick, frame or status pump; the menu-open fill is four rows. HP-2 allocations: none per frame. HP-3 DOM writes: four item texts per File open, none per frame. HP-8 caches:
listSlots' remembered rows are used as they are; the slot names add their own last-read cache.Screenshots / recordings
Previews from a host build (preview only, not the gallery): File > Load open on desktop and on a phone, sent to the owner in the project thread. The gallery is redrawn in the pinned Playwright image and pushed to this branch.
Notes for reviewers
Generated by Claude Code