Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
The docs preview for this pull request was removed when it closed. |
📸 Screenshot drift checkNo drift: the committed screenshots already match a fresh deterministic generation. ✅ |
eec2556 to
acad8db
Compare
It made the split tower's simulation up to 27% slower per game day than before it landed (about 8% even with the planned route cache), and no change may ship slower than 4.0. It returns in 4.2 with a re-route that costs nothing. #2272's note stays, since only a release consumes notes; its lines come out of the 4.1 changelogs when the release is cut. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ms7traFk8vS886Znni3dx3
acad8db to
fbf887b
Compare
|
Closing: Naftali chose to ship #2272 in 4.1 with the route cache (#2279) instead of reverting it. Generated by Claude Code |
What & why
Reverts #2272 (Modern riders stuck an hour in one line look for another way) for 4.1. The release perf check found it made the simulation slower than 4.0.0, and the standing rule is that nothing ships slower. Engine day bench (native release, best of 5, ms per game day): split tower 265 before #2272 vs 336 after (+27%), maxed Modern 478 vs 542 (+13%). The split tower's midnight-to-4 AM block (110 ms) is slower than 4.0.0's (97 ms). The #2272 thread's route cache brings it to about +8% on the split tower, and a cost-free re-route needs its own review, so the fix returns in 4.2.
This is held for Naftali's choice: merge this revert, or ship #2272 with the cache at about +8% on the split tower.
Type of change
Game mode impact
Modern only: restores 4.0.0 routing. Classic unchanged.
Quality gates
Clean
git revert -m 1of the #2272 merge; CI runs the full gates.Versioning
.changes/claude-project-thread-yuh4c2-revert-2272.md: app none, crate patch (the conformance lock digest moves back), readmes unchanged. A feature PR may not delete another PR's note, so #2272's note stays; when the 4.1 release PR is cut, its Player and Engine lines come out of both changelogs by hand, since the change ships in 4.2 instead.Complexity
Hot-path record (section 6): the diff removes the code #2272 added to the router and motion pass and restores the 4.0.0 code exactly; no new scan, cache or allocation.
Screenshots / recordings
docs/screenshots/features/metro-line-east.pngreturns to its pre-#2272 render.Notes for reviewers
The saved
linesrows were unchanged by #2272, so saves made on staging since then still load.https://claude.ai/code/session_01Ms7traFk8vS886Znni3dx3
Generated by Claude Code