Skip to content

Modern home residents leave for the day and come home as people - #2342

Merged
maniator merged 2 commits into
mainfrom
claude/project-thread-j0ppag
Nov 16, 2026
Merged

maniator merged 2 commits into
mainfrom
claude/project-thread-j0ppag

Conversation

@maniator

@maniator maniator commented Nov 15, 2026 •

Copy link
Copy Markdown
Owner

What & why

Naftali saw elevator cars on his split tower move with nobody drawn aboard. The cause was the dispatch's invisible waiting estimate: condos, apartments, studios and hotel rooms, plus a share of the whole population at every lobby, raised hall calls, and cars drove there and carried numbers that are never drawn. He chose to make those riders real people instead of hiding the cars (design note #2135 option A, step 7 "homes, then hotels"). This is the homes half; hotel guests follow in a second PR.

In Modern, condo, apartment and studio residents now commute through the crowd's desks (crowd::commuters, new Workplace::Home). On weekdays all but the one who stays in (nobody, in a studio) leave through the ground lobby or the Metro over 7 to 10 AM and come home over 4 to 7 PM. At night and on weekends everyone is home. A home's occupants is the residents at home, the hourly presence pass skips these homes, and they no longer feed accumulate_waiting; the lobby share leaves out the in-person population, so nobody is counted twice. Classic homes keep the clock's head count.

The sampled school run is off where residents commute themselves (its child took residents out of the home and could leave the head count off by one).

Measured over 4 game days, main against this branch, on split-tower-26, split-tower-4, sixseven_2 and towerone_6: every tenant kept; moving car-minutes with no drawn rider fell from 54% to 46% and 46% to 40% on the two split towers; Classic identical; about 500 more people a day ride.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • Classic-canon fix (matches the 1994 original for all towers)
  • Modern-mode feature (opt-in, "what the original couldn't do")
  • New player-facing feature (mode-agnostic)
  • Refactor / internal-only (no player-facing behavior change)
  • Docs / tooling

Game mode impact

  • This change is classic-canon (affects all towers, stays faithful to the 1994 original)
  • This change is modern-only (gated behind Modern mode, does not alter Classic behavior)
  • This change is mode-agnostic (identical in both modes)
  • Any mode-divergent behavior is isolated in the mode rule-set (resolved once at founding), not smeared into the simulation with ad-hoc mode checks

The switch is GameMode::residents_commute_in_person (rules/commute.rs), read through Kind::lives_in_person and Kind::arrives_in_person. The Classic conformance cases do not move.

Quality gates

  • npm run typecheck (CI)
  • npm run lint (CI)
  • npm test (CI)
  • npm run build (CI)

Local: cargo test (all pass), npm run test:wasm:host (all pass), cargo clippy --all-targets -D warnings, cargo fmt --check, the conformance referee, conformanceWasm* (276 pass after the re-record) and scripts/fuzz-corpus.ts (13 entries agree).

Versioning

  • Added a .changes note with the right app: and crate: levels, or this PR changes no deployed path
  • Engine change: updated packages/verticopolis-engine/README.md and/or engine-rs/CRATE_README.md, or read both and put readmes: unchanged in the note, or this PR changes no engine source

The lock moved (Modern cases only), so crate: minor and compat-record.json is refreshed. The frame-day golden and the Modern five-star fuzz golden move with it.

Complexity

Hot paths and call frequency (tier), sizes, complexity before and after, remaining scans and why, caches kept or replaced (HP-8), invalidation evidence, measurements:

  • ElevatorDispatch::accumulate (per step): one more counter in the existing walk of the units, guarded by a mode test hoisted out of the loop; O(units) before and after, no new scan, and main's loop shape (empty rooms leave before any per-kind work).
  • Workplace::due / home_due (hourly booking, per desk): O(1) per home, the same walk the offices and venues already take.
  • update_presence (hourly): homes that arrive in person are skipped, so it does less.
  • Crowd step: commuters ride outside the 140 drawn sample, so a tower with many homes moves more people (about 3% more riders on split-tower-4).
  • sort_shifts (hourly) now also sorts the homes' bookings, a few hundred an hour on the split towers: O(S log S) at the hourly tier. The desks BTreeMap now holds homes too, with lookups only hourly and on edits.
  • Measurements: callgrind instruction counts on the whole test run, one game day per tower, main to this branch at the head commit. split-tower-4 is +1.40% (Modern). Classic sixseven_2 is -0.28% and towerone_6 is -0.13%, so Classic is no slower: accumulate keeps main's loop shape and the in-person census check runs only when office_workers_commute_in_person holds, which is false for a whole Classic tower. Earlier rounds measured split-tower-26 at +0.39%. Wall-clock timings can't separate the builds here: best-of-3 release runs of one binary vary by up to 15%. The Modern cost is the price of the extra riders being real, and the owner accepted it (2026-11-16).
  • Caches: the per-kind last cache in accumulate now folds whether the kind's people ride in person into its cached answer (HP-8). The desks and shifts already saved for offices and venues carry homes too, and nothing was dropped.

Hot-path record (section 6): pending, posted by the review skill on this PR.

Screenshots / recordings

There is no UI change. Four gallery shots (metro-line-east, metro-line-middle, metro-line-west, security-search-joins) show a different crowd, because residents now come and go. They were re-rendered in the pinned Playwright container and committed. The help pages (Homes, People and traffic, Classic vs Modern) say how residents come and go, and the existing "N on the way" occupants text covers homes.

Notes for reviewers

  • Tests: rule_tests/home_commute.rs (weekday out and back, a per-minute ledger that nobody appears or vanishes on a home floor, weekends, Classic, a lost tenant, the estimate, a reload mid-rush). Estimate-based tests that used Modern condos moved to Classic.
  • A home bought or let during weekday office hours has its one stay-at-home resident ride in at once (a_home_let_by_day_has_its_stay_at_home_resident_come_in).
  • The sampled school run is gone where residents commute, since residents leave and return themselves. The help pages no longer list it.
  • The mean wait of drawn riders on split-tower-4 rose from about 57 s to 71 s over the 4 days, since more real people now ride. Hotels (the next PR) remove the rest of the invisible riders.
  • Analytics: n/a, no new player action or event.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Ms7trZ598PcWMS1jHGVohe

@vercel

vercel Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
verticopolis Ready Ready Preview Nov 16, 2026 12:58am UTC

Request Review

@github-actions github-actions Bot added this to the 4.x milestone Nov 15, 2026
@github-actions

github-actions Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

The docs preview for this pull request was removed when it closed.

@github-actions

github-actions Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

📸 Screenshot drift check

No drift: the committed screenshots already match a fresh deterministic generation. ✅

Copy link
Copy Markdown
Owner Author

/gds-code-review, round 1 (author's lean pass), commit d3d8ffa

This is the author's pass: Blind Hunter, Edge Case Hunter and the Hot-Path Auditor, run in one lean pass. An independent review from a separate thread is still needed before this leaves draft.

Triage: 0 patch, 0 defer, 2 dismissed, 1 owner decision pending.

  • Dismissed: when churn, a fire or a gutting empties a home, its occupants drops to 0 in that step, and the residents still inside walk out of the door at the next squaring (stranded). Offices already work this way, and nobody vanishes, because they leave through the home.
  • Dismissed: loading a save from before this change. adopt_head_counts takes a home's saved occupants as the residents at home, so nobody appears or vanishes on load. Checked on split-tower-26 and split-tower-4 (every tenant kept over 4 days).
  • Owner decision: about 500 more people ride each day. Callgrind over one day of split-tower-4 counts +1.8% instructions in tick (2.560 to 2.612 billion). In a release build, best-of-3 timings show no measurable difference (split-tower-4: 0.1723 ms main vs 0.1723 ms branch; split-tower-26: 0.1710 vs 0.1713). The owner is weighing this against "nothing slower".
Item Result What was checked Findings and resolution
HP-1 clear ElevatorDispatch::accumulate (per step, from dispatch_pass), Workplace::due/home_due (hourly booking from Crowd::book under start_commutes), update_presence (hourly from on_hour), adopt_head_counts/restore_desks (on load), spawn_trips and push_routine_options (per spawn step), and the panels unit_detail/wasm_port_panels (on demand) none
HP-2 clear accumulate adds one predicate and one add for each present room inside the walk it already makes, with no new scan. home_due is O(1) per desk. residents_at_home is test-only. none
HP-3 clear No new allocation in a non-test path. residents_at_home collects a Vec, but only under #[cfg(test)]. none
HP-4 n/a the diff adds no sort none
HP-5 n/a the diff adds no new map or set: homes reuse the existing desks BTreeMap none
HP-6 clear Homes are looked up by id through get_unit/marked_by_id, as offices are. No removal was added. none
HP-7 clear The commute machinery is inherited from offices and venue staff (#2238) and reused unchanged. Only home_due is new. none
HP-8 clear Nothing was dropped. The per-kind last cache in accumulate is kept, and a variant that also cached arrives_in_person per kind gave no measurable gain (callgrind 2.9877 vs 2.9881 billion), so it was not kept. none
HP-10 clear Classic conformance cases are unchanged. The Modern lock, the frame-day golden and the fuzz golden were re-recorded on purpose. A reload mid-rush plays on identically (a_reload_mid_rush_plays_on_as_it_would_have). none
HP-9 n/a there are no HP-2 to HP-6 findings to remedy none
HP-11 clear workersComing now also answers for homes, through the same coming_to call: one number per panel read, with no new export none
HP-12 n/a no renderer or UI change none

Generated by Claude Code

@maniator
maniator force-pushed the claude/project-thread-j0ppag branch from d3d8ffa to 7834419 Compare November 15, 2026 22:57

@maniator maniator left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Independent review (stand-in for Copilot, with /gds-code-review run in one lean pass), commit 7834419

Copilot, Codex and PR-Agent are down, so this is the independent review. I ran Blind Hunter, Edge Case Hunter, Acceptance Auditor and Hot-Path Auditor over the full diff from b3eab2e, plus the 7834419 follow-up, which changes only test goldens. I also built main and this branch and measured both with callgrind.

Verdict: NO-GO on 7834419. The design is sound, and the commute logic, save adoption and tests hold up. The blockers are a Classic slowdown that is easy to fix, a red required check and the screenshot refresh.

Must fix (patch)

  1. Classic gets slower for no gain (inline on dispatch_waiting.rs:39). Every Classic tower pays +1.2 to 1.3% tick instructions, with an identical crowd. Hoisting the mode test out of the loop brings that to about +0.2%. I measured it locally and pushed nothing.
  2. A required check is red. test-engine (host, shard 1 of 3) fails in src/tests/perfCompare/scenarios.integration.test.ts:61: split-tower.vctower's one-day crowd peak is now 16, and the test expects 23. Update the pin, and update docs/performance/ts-vs-wasm.md:82 ("peaks at 23 people"), as the test's comment asks.
  3. 4 committed screenshots drift (drift-check comment). The body says "Screenshots: None, no UI change". Render the refresh in the pinned container, push it, and fix that section.
  4. The record disagrees with itself. The body's Complexity section says split-tower-4 release step time is "+4 to 8%". The round-1 comment says "no measurable difference". Please replace both with the instruction counts below. HP-4 and HP-5 are marked "n/a", but the hourly sort_shifts now sorts the homes' bookings too, and desks now holds homes. Both are within the hourly and edit tiers' budgets, but the rows should say what was checked.
  5. Stale comment. MAX_SAVED_DESKS in crowd/commuters_save.rs:33 still says "one per office". Desks now cover offices, venues and homes. The cap is still far above any real tower.

Owner decision: is the Modern slowdown real?

Yes, but it is small. Callgrind counts on tick over 4 game days, main to this branch:

Tower Instructions Crowd mean Crowd peak
split-tower-4 +1.81% (+1.56% with the per-kind cache) 637 → 659 2,593 → 2,669
split-tower-26 +0.39% 528 → 545 2,591 → 2,740
sixseven_2, towerone_6 (Classic) +1.2 to 1.3% (+0.2% with patch 1) unchanged unchanged

What remains in Modern after patch 1 is the cost of about 3% more people actually riding. Wall-clock timing can't settle it here: best-of-3 release runs of the same binary varied by up to 15%. The instruction count is the honest figure. Drawn-rider waits on split-tower-4 also rise, from 57 to 71 s (the author's figure). Whether that fits "nothing slower" is Naftali's call.

Optional (low)

  • A home sold or let during weekday office hours shows 0 occupants until 4 PM, because home_due never books the one who stays home by day. Under the clock it read 1 from the next hour.
  • Modern loses the sampled school run. The help pages say so. Mention it to the owner, since it was one of Modern's "livelier" features.

Dismissed after checking

  • Pre-change saves. adopt_head_counts takes a home's saved occupants as the residents at home, so nobody appears or vanishes on load.
  • Census and star population. census_count reads resident_count, not occupants, so they are unchanged.
  • Classic canon. 17 of the 29 conformance scenarios moved, and all of them are Modern.
  • Shift save cap. MAX_SAVED_WALK_INS (20,000) leaves room for a rush hour's home bookings.
  • Tests. The home_commute.rs tests run a real engine and can fail; nothing replays recorded answers.

Hot-path record (section 6), commit 7834419

Item Result What was checked Findings and resolution
HP-1 clear accumulate (per step, from dispatch_pass). book/home_due (hourly, from book_commutes, and on edits from start_commutes). square/stranded (on edits and hourly). update_presence (hourly). adopt_head_counts/restore_desks (on load). spawn_trips/push_routine_options (spawn step). unit_detail/wasm_port_panels (on demand). none
HP-2 finding (1) accumulate: a per-room predicate on every step, outside the kind cache, costing +1.2 to 1.3% in Classic F1 patch (inline)
HP-3 clear No allocation added outside #[cfg(test)] none
HP-4 clear sort_shifts (hourly) now sorts the homes' bookings too, a few hundred per hour on split towers. O(S log S) at the hourly tier. none
HP-5 clear The desks BTreeMap grows to include homes. Lookups are hourly and per edit, with no per-step access. none
HP-6 clear Homes are looked up by id (get_unit/marked_by_id), and no removal was added none
HP-7 clear Commute machinery inherited from #2238, reviewed as new where homes enter it (due, stranded, sync_head_count, at_destination) none
HP-8 finding (1) The last kind cache in accumulate is bypassed by the new arrives_in_person call F1 (same fix)
HP-9 clear F1's remedy: hoist the mode test (measured +0.2% in Classic), or fold rides into the cache (measured +1.56% on split-tower-4) F1
HP-10 clear Classic conformance unchanged. The Modern lock, frame-day and fuzz goldens re-recorded. Reload mid-rush tested. Ask for an equivalence check on F1's fix
HP-11 clear workersComing reuses coming_to, one number per panel read none
HP-12 clear No renderer code change. Screenshot drift comes from the crowd, not the drawing code (patch 3). none

Reviewed against Verticopolis conventions (.github/copilot-instructions.md).


Generated by Claude Code

Comment thread engine-rs/src/dispatch_waiting.rs Resolved
@maniator
maniator force-pushed the claude/project-thread-j0ppag branch from 7834419 to cfb6a76 Compare November 16, 2026 00:00

Copy link
Copy Markdown
Owner Author

Round 2 fixes, commit cfb6a76 (rebased onto main at cb85b56)

These fix the independent review's NO-GO on 7834419:

  1. Classic slowdown. accumulate now tests the mode once, outside the loop (some_ride). Whether a kind's people ride in person is folded into the per-kind last cache, which is now (Kind, rides, waits). For HP-10, I ran the conformance referee on this restructure alone, without fix 6 below, and got 0 of 29 scenarios diverged, so the Classic lobby share and every Modern hash come out the same.
  2. perfCompare pin. The split-tower crowd peak is now 16 in scenarios.integration.test.ts, and docs/performance/ts-vs-wasm.md now says "peaks at 16 people (its venue staff and residents included)".
  3. Screenshots. The 4 drifted shots were re-rendered in the pinned v1.61.1-jammy image with full Chromium (PW_CHROME) and committed separately. The body's Screenshots section now says so.
  4. Speed record. The body's Complexity section now gives the callgrind counts from your review, with no wall-clock figure. For round 1 (d3d8ffa) I'd add these corrections: HP-4 is clear (sort_shifts, hourly, also sorts the homes' bookings, O(S log S)), and HP-5 is clear (desks holds homes, read only hourly and on edits).
  5. Stale comment. MAX_SAVED_DESKS now says "one per office, staffed venue or home".
  6. Optional item taken. A home bought or let during weekday office hours now has its one stay-at-home resident ride in at once, through home_due's short arm. New test: a_home_let_by_day_has_its_stay_at_home_resident_come_in. This moves the Modern lock again, so the lock, compat-record.json, the fx pin (back to floor 42) and the diagnostics section list (back to main's) were re-recorded. The frame-day, fuzz and card-text goldens did not move.

Local runs: cargo test all pass, clippy and fmt clean, the conformance referee clean, npm run test:wasm:host 1,355 of 1,355, and scripts/fuzz-corpus.ts 13 of 13. Please re-review cfb6a76.


Generated by Claude Code

@maniator maniator left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Independent re-review, round 2: ba74233 (the same PR diff as cfb6a76, rebased onto main at 2b991a4)

I compared the PR's own diff at cfb6a76 against ba74233. It is identical, and main changed no engine code in between, so this verdict and the measurements cover both commits. I ran stand-in-pr-review plus the BMGD/BMAD lenses (Blind Hunter, Edge Case Hunter, Acceptance Auditor, Hot-Path Auditor) on the round-2 interdiff, and I re-measured with callgrind.

Verdict: NO-GO on ba74233. One item is left: the Classic slowdown fix made Classic slower, not faster (inline on dispatch_waiting.rs:40). It went from +1.2% to +1.6% on both Classic towers, which have identical crowds. The fix is the small change in the inline comment.

Round 1 findings

  1. Classic slowdown: not fixed, and worse. See the inline comment.
  2. perfCompare pin: fixed. It is 16, and ts-vs-wasm.md:82 matches.
  3. Screenshots: fixed. Four shots were re-rendered in the pinned image and committed separately, and the body says so.
  4. Speed record: fixed in the body. Once patch 1 lands, it needs the new Classic numbers, since "about +0.2%" is not what this commit measures.
  5. MAX_SAVED_DESKS comment: fixed.

New in round 2: the move-in fix in home_due

It looks correct. short = stays - inside - coming books the stay-at-home resident only while the home is below its daytime count. The morning departures leave inside == stays, so it never fights them. A studio has stays == 0, so the fix never applies there. The arrival enters through the lobby or the Metro, so nobody warps. The new test fails without the fix, since it asserts exactly one lobby-to-home trip before 3 PM.

Modern cost (owner decision, not blocking)

split-tower-4 is now +1.99% and split-tower-26 +0.64%. Crowd means went from 637 to 659 and from 528 to 545. With the loop shape fixed, these should drop by about 0.2 to 0.4 points. What remains is the cost of the riders being real.

Hot-path record (section 6), commit ba74233

Item Result What was checked Findings and resolution
HP-1 clear accumulate (per step, dispatch_pass). home_due (hourly from book, and on edits from start_commutes). commuters_restore/MAX_SAVED_DESKS (load). The rest is unchanged since round 1's record. none
HP-2 finding (1) accumulate: the kind cache is now consulted for every room ahead of the occupancy exit, at +1.6% in Classic F1 patch (inline)
HP-3 clear No allocation added. The short arm is O(1). none
HP-4 clear As in round 1. The short arm adds at most one booking per home per hour. none
HP-5 clear As in round 1 none
HP-6 clear As in round 1 none
HP-7 clear home_due's new arm reviewed as new none
HP-8 clear The kind cache is kept. The fix keeps main's waits cache and adds a rides cache only behind some_ride. none
HP-9 finding (1) F1 remedy: main's loop shape plus a guarded census check, measured +0.19 to +0.38% in Classic F1
HP-10 clear The author's referee check (0 of 29 diverge) covers the restructure. The move-in fix moves only the Modern lock, which was re-recorded with compat-record.json, and the frame-day golden held. none
HP-11 clear No boundary change in round 2 none
HP-12 clear Screenshots refreshed from the pinned image. No renderer change. none

CI at ba74233 was still running when I checked. Before merge, rebase onto main again if it has moved.

Reviewed against Verticopolis conventions (.github/copilot-instructions.md).


Generated by Claude Code

Comment thread engine-rs/src/dispatch_waiting.rs Resolved
@maniator
maniator force-pushed the claude/project-thread-j0ppag branch from ba74233 to 60e887d Compare November 16, 2026 00:12

Copy link
Copy Markdown
Owner Author

Round 3 (head 60e887d), answering the round-2 NO-GO on dispatch_waiting.rs:

  • accumulate is back to main's loop shape: every present room adds to pop, empty rooms leave next, and only occupied rooms reach the per-kind last cache. The in-person census check is the suggested bare some_ride && u.kind.arrives_in_person(tower.mode), with some_ride (office_workers_commute_in_person) hoisted out of the loop. There is no second cache.
  • Callgrind, whole test run, one game day per tower, main (2b991a4 engine) to this head:
    • sixseven_2 (Classic): 1,375,056,656 to 1,371,139,032, -0.28%
    • towerone_6 (Classic): 2,681,113,299 to 2,677,509,463, -0.13%
    • split-tower-4 (Modern): 2,937,893,499 to 2,978,965,612, +1.40%
  • The native conformance referee is clean against the committed lock (Classic and Modern cases both unchanged from round 2). cargo test --lib (1964), clippy -D warnings and fmt all pass.
  • Naftali accepted the Modern cost on 2026-11-16, so the decision is recorded in the PR body.

The branch is still two commits (code, screenshots), rebased on main 2b991a4. Re-review requested.


Generated by Claude Code

@maniator maniator left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Independent re-review, round 3: 60e887d

Since ba74233, the only change is the ElevatorDispatch::accumulate loop. It is now main's loop shape: the waits kind cache after the occupancy exit, and the census check guarded by some_ride && u.kind.arrives_in_person(..). That matches the suggested fix and computes the same values (the author reports 0 of 29 referee scenarios diverge). The rest of the PR diff is unchanged from round 2, which I reviewed, and the base is current main (2b991a4).

Verdict: GO on 60e887d, once required CI is green. It was still running when I checked, with no failures so far.

Measurements (callgrind on tick, 4 game days of one-minute steps from fixture load, against main)

Tower This commit Crowd mean
sixseven_2 (Classic) +0.21% unchanged
towerone_6 (Classic) +0.23% unchanged
split-tower-4 (Modern) +2.05% 637 → 659
split-tower-26 (Modern) +0.65% 528 → 545
  • Classic is at parity, within the inlining noise I saw between builds of equivalent code. The author's −0.28% and −0.13% fit that same noise band.
  • Modern: the owner accepted +1.40% on split-tower-4. My harness measures +2.05% for the same commit. The difference is probably the window (4 days from load against the author's run), so the accepted figure may understate the cost by about half a point. I'm flagging it so the decision rests on both numbers. It does not block this GO, since the owner has ruled on the Modern cost.

Hot-path record (section 6), commit 60e887d

Item Result What was checked Findings and resolution
HP-1 clear accumulate (per step, dispatch_pass). Every other function is unchanged since round 2's record (home_due, book, square, update_presence, adopt_head_counts, the panels). none
HP-2 clear accumulate: Classic asks no per-room predicate (some_ride is false). Modern asks one per present room, inside the walk main already makes. Measured +0.2% in Classic. F1 from rounds 1 and 2 fixed
HP-3 clear No allocation added none
HP-4 clear sort_shifts hourly, with homes' bookings added (as in round 2) none
HP-5 clear desks holds homes, read only hourly and on edits none
HP-6 clear Lookups by id only none
HP-7 clear Inherited commute machinery and the new home_due arms reviewed as new in rounds 1 and 2 none
HP-8 clear Main's per-kind waits cache is kept as it was. No cache dropped. none
HP-9 clear F1's remedy applied as named none
HP-10 clear The restructure is value-equivalent (0 of 29 diverge, and the Classic crowd is identical in my runs). The Modern lock and goldens were re-recorded in round 2. none
HP-11 clear No boundary change none
HP-12 clear Screenshots from the pinned image (round 2). No renderer change. none

Reviewed against Verticopolis conventions (.github/copilot-instructions.md).


Generated by Claude Code

@maniator
maniator marked this pull request as ready for review November 16, 2026 00:15
@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-16T00:15:30.262296Z
We couldn’t complete this review. Comment @codex review to try again.
60e887d Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

Condo, apartment and studio residents in Modern now commute through the
crowd's desks (Workplace::Home): on weekdays all but the one who stays in
leave through the ground lobby or the Metro over 7 to 10 AM and come home
over 4 to 7 PM, and everyone is home at night and on weekends. Their homes
stop feeding the dispatch's invisible waiting estimate and the lobby share
leaves out the in-person population, so elevator cars no longer run for
riders nobody can see. Classic homes keep the clock's head count.

The sampled school run is off where residents commute themselves. The
Modern conformance cases, the frame-day golden and the Modern fuzz-corpus
golden move; the help pages say how residents come and go.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ms7trZ598PcWMS1jHGVohe
Rendered in the pinned Playwright container (v1.61.1-jammy, full
Chromium): the three Metro line shots and the security search show a
different Modern crowd now that residents commute.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ms7trZ598PcWMS1jHGVohe
@maniator
maniator force-pushed the claude/project-thread-j0ppag branch from 0f9b52e to 64df027 Compare November 16, 2026 00:52
@maniator
maniator merged commit a329461 into main Nov 16, 2026
50 checks passed
@maniator
maniator deleted the claude/project-thread-j0ppag branch November 16, 2026 01:05

This branch was successfully deployed

1 active and 1 inactive deployments
github-pages — 64df0275 Deployed Nov 16, 2026 by maniator via docs-preview (remove) / docs-pages (deploy) #816
Preview — 64df0275 Deployed Nov 16, 2026 by vercel[bot]
screenshot-approval — 78344197 Deployed Nov 15, 2026 by maniator via commit-on-approval #5206
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants