Repository navigation
Start new Modern towers with bridge floors between rooms off - #2345
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
75f09d5 to
1088a9b
Compare
📸 Screenshot drift checkNo drift: the committed screenshots already match a fresh deterministic generation. ✅ |
maniator
left a comment
There was a problem hiding this comment.
Independent review: CONDITIONAL GO at 1088a9b
I ran /gds-code-review and the stand-in Copilot pass (Codex hit its usage limit on this PR, and Copilot is down) as one lean pass with three lenses: Blind Hunter, Edge Case Hunter and Acceptance Auditor. The diff mixes a gameplay default with UI and analytics plumbing, so gds is the right skill.
Condition: fix the one patch finding (the em-dash in the new test file, inline). It is a one-character change, and the verdict carries to the fix commit if that line is the only change.
What I checked
- Every founding path goes through the dialog.
titleScreen.ts:81andUI.ts:172both reachnewTowerModaland thensaveLoad.newGamewithstartUnbridged. No other player path founds a tower. The toolingEngine.newGame(seed, mode)and the scenes still found bridged, so only00b-onboarding-modernchanges, as the PR says. - Existing saves keep their setting. The engine is untouched.
load/assemble.rs:40still reads a missingautoBridgeas bridged for Modern and forces bridged for Classic. - Classic is unchanged.
startUnbridgedstaysfalseoutside the Modern branch, and nofound_bridgedis sent. The moved Classic test still proves the box is ignored: the box is now unticked, which would found a Modern tower unbridged, yet Classic still getsfalse. - Analytics.
found_bridgedandauto_bridgeare added toAppActionName.auto_bridgereports the engine's answer and is not sent if the flip throws. The data map section and the dashboard tile both match the code, and the tile's["action","detail"]breakdown is the same shape as the other ActionsTable tiles. - Help.
settings.mdxandfloors-and-lobbies.mdxnow say the switch starts off.first-tower.mdxandclassic-vs-modern.mddon't depend on bridging, so they need no change. - Tests are honest. The analytics send is a
vi.fnspy, no engine runs, and each new assertion fails if the default flips back. - History and version. The branch has two logical commits, is rebased on
main(d0df552) and has no merge-from-main commits. The change note isapp: patchandcrate: none, which fits the 2026-11-14 bump rule for a behavior correction. - CI. All 39 check runs on
1088a9bare green or skipped by path, including thetest, e2e shards, smoke, help-site build and everycapture / shootshard. So the screenshot drift check passes with the re-rendered00b-onboarding-modern.png.
Findings
| # | Severity | Triage | Finding |
|---|---|---|---|
| 1 | Low | patch | newTowerModal.integration.test.ts:32: a new file adds an em-dash. Details are inline. |
| 2 | Low | optional | The dashboard tile counts events, not players. Someone who flips the Settings switch on, off and on again counts three times. The data map says "how often", which matches the tile. Only the PR body says "how many players". To count players, add a unique-users series (series("app_action", "Players", "dau")). Otherwise leave it. |
| 3 | Low | optional | The data map and the tile description say "From 2026-11-15". Players get the new default only when the next release deploys. Both codes are new, so no data from before the change gets mixed in, but naming the release would be more accurate. |
| 4 | Nit | optional | In uiCallbacks.test.ts, the trackAppAction spy now lives in the hoisted object named files, next to the file-module spies. A separate vi.hoisted object would read more clearly. |
I dismissed one finding: found_bridged is sent just before onFound. If founding then throws, the event still reports the player's choice, which is what the data map promises.
Hot-path record (section 6), commit 1088a9b, whole diff
The diff touches src/game/, src/ui/ and src/analyticsCore.ts, so the table applies.
| Item | Result | What was checked | Findings and resolution |
|---|---|---|---|
| HP-1 | clear | newTowerModal commit handler: a click in the New Tower dialog, once per founding. onToggleAutoBridge: the Settings checkbox change listener (uiSettings.ts:80), once per user flip. AppActionName: a type union with no runtime cost. Neither function is called per frame, per tick or per command. |
none |
| HP-2 | clear | No loops or scans added. querySelector runs once per click on the open dialog. |
none |
| HP-3 | clear | One small {action, detail} object per click, built inside trackAppAction. |
none |
| HP-4 | n/a | The diff adds no sort or ordered rebuild. | none |
| HP-5 | n/a | The diff adds no container or hashing. | none |
| HP-6 | n/a | The diff adds no lookup by id or removal. | none |
| HP-7 | n/a | No algorithm was ported or inherited. The test block move is test code. | none |
| HP-8 | n/a | No cache was added, dropped or bypassed. | none |
| HP-9 | n/a | HP-2 to HP-6 have no findings. | none |
| HP-10 | clear | Engine results are unchanged. The switch still shows the engine's answer, and analytics only reads that value. | none |
| HP-11 | n/a | The WASM boundary, the hosts and the build are untouched. flipAutoBridge is called once, as before. |
none |
| HP-12 | clear | No per-frame render or HUD work. The dialog template changes one attribute. | none |
Verdict: CONDITIONAL GO at 1088a9b42f52738d1e100c8ed67b79ade65482f8. The only condition is finding 1. After that commit, check that its diff touches only that line before arming auto-merge.
Reviewed against Verticopolis conventions (.github/copilot-instructions.md).
Generated by Claude Code
4d3ff70 to
52f0af8
Compare
52f0af8 to
65e328e
Compare
6e04a28 to
e87f63e
Compare
|
The Fixed in e87f63e. I folded the two new Auto-merge stays off while the 4.5.1 release PR (#2348) is open. Generated by Claude Code |
e87f63e to
677ea16
Compare
677ea16 to
711c95a
Compare
The New Tower window's "Bridge floors between rooms" box now starts unticked, so a new Modern tower is founded unbridged unless the player ticks it. Existing towers keep the setting their save carries; the engine and save format are unchanged. Adds two app_action codes, found_bridged (the box at a Modern founding) and auto_bridge (the Settings switch), with their data map rows and a dashboard tile, and updates the help pages that described bridging as on by default. The New Tower dialog tests move into their own file. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ms7trXSDbcT7Vci3GZYmQw
Rendered in the pinned mcr.microsoft.com/playwright:v1.61.1-jammy image (ONLY=first-run); the Classic shot in the same scene came out byte-identical. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ms7trXSDbcT7Vci3GZYmQw
711c95a to
7d7bed2
Compare
Requested by Naftali · project thread
What & why
A new Modern tower now starts with Bridge floors between rooms off (owner, 2026-11-15). The New Tower window's box starts unticked, so the tower is founded unbridged unless the player ticks it.
Why it was on: when the switch was added it was an opt-out on top of the bridging every tower already did (the 1994 behavior, which Classic keeps), so "on" kept play unchanged for existing players. #2246 later reworded the "Don't bridge" box to "Bridge floors between rooms" and kept it checked to preserve that same default.
Only the founding default moves. The engine, its
foundTowerflag and the save format are unchanged: a save carries its ownautoBridge, and an older save without the field still reads as bridged, so every existing tower keeps the setting it had.Analytics (standing rule): two
app_actioncodes,found_bridged(the box at a Modern founding,on/off) andauto_bridge(the Settings switch, with the engine's answer), with a data map section and a dashboard tile, so we can see how many players turn it back on. Help: Settings and Floors and lobbies now say it starts off.Closes n/a: owner request in the project thread.
Type of change
Game mode impact
A Classic founding still pins bridged and sends no
found_bridged(tested).Quality gates
npm run typechecknpm run lintnpm test(the touched suites pass locally: the newnewTowerModal.integration.test.ts,uiDialogs.integration.test.ts,uiCallbacks.test.ts,analyticsDataMap.test.ts,newTower.test.ts, the file-size guard; full run left to CI)npm run build(VC_TOOLING=1, in the pinned Playwright image)Versioning
.changesnote with the rightapp:andcrate:levels, or this PR changes no deployed pathpackages/verticopolis-engine/README.mdand/orengine-rs/CRATE_README.md, or read both and putreadmes: unchangedin the note, or this PR changes no engine sourceapp: patch(a default the player notices, no new feature),crate: none.Complexity
n/a: one checkbox default in a dialog and one
trackAppActionper founding and per Settings toggle; no loop, scan or cache is touched.Hot-path record (section 6): no hot-path surface beyond two one-shot analytics sends on user clicks.
Screenshots / recordings
docs/screenshots/00b-onboarding-modern.png, re-rendered in the pinnedmcr.microsoft.com/playwright:v1.61.1-jammyimage (ONLY=first-run). The Classic shot from the same scene came out byte-identical.Notes for reviewers
uiDialogs.integration.test.ts(a ratchet file) intonewTowerModal.integration.test.ts, which mocks the analytics send to check the reported choice.settings-modern(02b-settings-modern) founds through the tooling handle, which stays bridged, so that shot does not change.Generated by Claude Code