fix: publish release artifacts and the Homebrew cask - #5
Merged
Conversation
A GitHub Release created by release-please with the default GITHUB_TOKEN does
not emit a `release: published` event, so release-build.yml never ran and
v1.2.0 shipped without a DMG. The build is now called directly from
release-please.yml when a release is cut, checks out the released tag, and is
re-runnable by hand through workflow_dispatch.
Tags drop the component prefix (`v1.2.1`, not `mounty-v1.2.1`) so `${TAG#v}`
yields the real version and the download URL matches what the cask
interpolates.
The cask update moves out of this repository: instead of writing a heredoc
into the tap, the release sends a "cask-release" repository_dispatch to
maptic/homebrew-tap, which owns the cask and recomputes the sha256 from the
published asset. Without HOMEBREW_TAP_TOKEN the release still succeeds and
only the bump is skipped.
Generated-by: claude-opus-5
`mounty-v1.2.0` puts the repository name in a tag inside that same repository, which makes release URLs read `maptic/mounty/releases/tag/mounty-v1.2.0`. The repo holds one app, so neither the component prefix nor the `v` carries information: tags are now `1.2.1`, and the cask interpolates the version straight into the download URL. Generated-by: claude-opus-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mounty 1.2.0 shipped with no downloadable artifact: a GitHub Release created by release-please
with the default
GITHUB_TOKENdoes not emit arelease: publishedevent, sorelease-build.ymlnever ran. This wires the pipeline up end to end and moves cask maintenance into
maptic/homebrew-tap.release-build.ymlbecomes a reusable workflow called byrelease-please.ymlwhen a releaseis cut. It checks out the released tag and is re-runnable by hand:
gh workflow run release-build.yml -f tag=1.2.1.1.2.1, notmounty-v1.2.1. One app per repo, so the component prefixonly made release URLs redundant. The existing tag and release were renamed to
1.2.0.Casks/mounty.rbis replaced by acask-releaserepository_dispatch. The tap owns the cask and recomputes thesha256from the published assetinstead of trusting the payload. Without
HOMEBREW_TAP_TOKENthe release still succeeds and onlythe bump is skipped.
Follow-up
Add
HOMEBREW_TAP_TOKEN(fine-grained PAT,contents: writeonmaptic/homebrew-tap) to thisrepository's secrets to enable the automatic bump.
Story:
docs/stories/024-homebrew-tap-distribution.md