fix: ignore warnings for duration in column summaries. - #10531
Open
kjgoodrick wants to merge 1 commit into
Open
Conversation
These are expected to fail and the fallback still produces the chart as expected
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Binning duration columns is expected to fail and the fallback still produces the chart as expected. This change stops the warning from being emitted if the column type is a duration. I think a more robust fix would require support for durations/timedeltas in Vega-lite. For now the chart is good enough that emitting the warning is not helpful.
📝 Summary
Closes #10530
📋 Pre-Review Checklist
✅ Merge Checklist