Bump Testcontainers from 4.12.0 to 4.14.0 to clear the SSH.NET advisory - #43
Merged
Merged
Conversation
Testcontainers 4.12.0 pulls SSH.NET 2025.1.0 transitively, which carries GHSA-q939-rpr3-3284 (high: ScpClient recursive download allows arbitrary file write via server-controlled SCP filenames). Pool never uses SSH.NET directly; the only path is Testcontainers in samples/Smtp.Pool.Integration.Tests. Testcontainers 4.14.0 depends on the patched SSH.NET 2026.0.0, so the bump clears NU1903 and lets samples/Smtp.Pool.slnx build again. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018oQ2H2BWF3GVGTR9udJTRG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the SSH.NET Dependabot alert (GHSA-q939-rpr3-3284 / CVE-2026-48798, high).
Pool never references SSH.NET directly. The only path is
Testcontainers4.12.0 →SSH.NET2025.1.0, insamples/Smtp.Pool.Integration.Tests. Testcontainers 4.14.0 depends on the patchedSSH.NET2026.0.0, so bumping the direct dependency clears the advisory without pinning a transitive package.The advisory currently fails
NU1903(warning-as-error) on restore, which breakssamples/Smtp.Pool.slnxlocally and thesubmit-nugetjob in the dependency-submission workflow, which restores every project in the repo. The.NET Testsworkflow is unaffected — it only buildsPool.slnx, which excludes the sample test projects.Verified:
SSH.NETresolves to 2026.0.0 in the integration-test assets,samples/Smtp.Pool.slnxbuilds clean, and the build gate (format → build → test) is green onPool.slnx— 144/144 passing, coverage 99.32/92.44/95.31.🤖 Generated with Claude Code
https://claude.ai/code/session_018oQ2H2BWF3GVGTR9udJTRG