Skip to content

Bump package versions to latest upstream releases - #51

Open
github-actions[bot] wants to merge 1 commit into
mainfrom
bump-versions-20260907
Open

github-actions[bot] wants to merge 1 commit into
mainfrom
bump-versions-20260907

Conversation

@github-actions

@github-actions github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Automated bump from check-releases.yml. Merging rebuilds and republishes the apt repository.

@gafferongames

Copy link
Copy Markdown
Contributor

Pull Request Review: PR #51 (bump-versions-20260907)

Head SHA: 9dfd70db15f38829b3d7f7edaa3151d9483a1298
Base: origin/main
Verdict: CHANGES REQUESTED
Score: 3/10


Executive Summary

PR #51 attempts to bump upstream versions in versions.env (serialize 1.16.0, reliable 1.4.2, netcode 1.4.5, yojimbo 1.12.1, schema 2.4.0). While git 3-way mergeability against origin/main is clean, this PR cannot be merged in its current state for two critical reasons:

  1. Packaging Breakage & CI Failure: In remote CI run 34107867178 on exact head commit 9dfd70db15f38829b3d7f7edaa3151d9483a1298, all 10 matrix builds failed when compiling yojimbo. Upstream yojimbo v1.12.1 changed its CMake runtime output directory from ${CMAKE_CURRENT_SOURCE_DIR}/bin to ${CMAKE_BINARY_DIR}/bin (and added native CTest support). As a result, packages/yojimbo/debian/rules (and official/yojimbo/debian/rules) hardcoding $(CURDIR)/bin/test fails with:
    make[1]: /__w/apt/apt/build/yojimbo/yojimbo-1.12.1/bin/test: No such file or directory
    make[1]: *** [debian/rules:20: override_dh_auto_test] Error 127
    
  2. Stale Upstream Versions: The PR was generated 14 days ago and is already superseded by newer upstream releases across all 5 packages.

Detailed Verification Evidence

1. 3-Way Merge Verification

Executed git merge-tree --write-tree origin/main 9dfd70db15f38829b3d7f7edaa3151d9483a1298:

  • Tree SHA: 5a5522236b723aa2cc27c8b11cdc2234271e9ff7
  • Exit Code: 0 (clean merge against base, no merge conflicts).

2. Diff Inspection

Changes in versions.env:

-SERIALIZE_VERSION=1.15.0
-RELIABLE_VERSION=1.4.0
-NETCODE_VERSION=1.4.3
-YOJIMBO_VERSION=1.10.1
-SCHEMA_VERSION=2.0.0
+SERIALIZE_VERSION=1.16.0
+RELIABLE_VERSION=1.4.2
+NETCODE_VERSION=1.4.5
+YOJIMBO_VERSION=1.12.1
+SCHEMA_VERSION=2.4.0

3. Release Check Script (./scripts/check-releases.sh)

Running ./scripts/check-releases.sh against commit 9dfd70db15f38829b3d7f7edaa3151d9483a1298 yielded exit code 1:

serialize: pinned 1.16.0, latest 1.17.0
reliable: pinned 1.4.2, latest 1.4.5
netcode: pinned 1.4.5, latest 1.4.8
yojimbo: pinned 1.12.1, latest 1.13.5
schema: pinned 2.4.0, latest 2.5.0

All pinned versions in PR #51 are already behind the latest upstream releases.

4. Negative Control / Red-Test

Verified the sensitivity of ./scripts/check-releases.sh:

  • Positive Control: Temporarily set versions.env to current latest upstream versions -> all pinned versions are current, Exit Code: 0.
  • Negative Control: Mutated SERIALIZE_VERSION=9.9.9 -> serialize: pinned 9.9.9, latest 1.17.0, Exit Code: 1.
    The verification script reliably discriminates between matching and non-matching versions.

5. Remote CI Build Implications & Root Cause Analysis

Inspected workflow run 34107867178 triggered on head commit 9dfd70db15f38829b3d7f7edaa3151d9483a1298:

  • autopkgtest-schema: Passed (51s).
  • Matrix build jobs across all 10 environments (Debian 12/13, Ubuntu 22.04/24.04/26.04 on amd64/arm64): Failed with exit code 2.
  • Log error:
    debian/rules override_dh_auto_test
    make[1]: /__w/apt/apt/build/yojimbo/yojimbo-1.12.1/bin/test: No such file or directory
    make[1]: *** [debian/rules:20: override_dh_auto_test] Error 127
    make: *** [debian/rules:7: binary] Error 2
    dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2
    
  • Root Cause: Upstream yojimbo commit for v1.12.0/v1.12.1 updated CMakeLists.txt to set CMAKE_RUNTIME_OUTPUT_DIRECTORY to ${CMAKE_BINARY_DIR}/bin and integrated ctest. The Debian package rules in packages/yojimbo/debian/rules and official/yojimbo/debian/rules still expect the binary at $(CURDIR)/bin/test.

Required Actions Before Merging

  1. Update packages/yojimbo/debian/rules (and official/yojimbo/debian/rules) to properly locate the test executable under the build directory or rely on dh_auto_test (using CTest).
  2. Re-run ./scripts/check-releases.sh --update to bump all packages to their latest upstream versions (serialize 1.17.0, reliable 1.4.5, netcode 1.4.8, yojimbo 1.13.5, schema 2.5.0).
  3. Ensure CI passes cleanly before merging.

READ-COST: reader=Emma model=gemini-2.5-pro seconds=168 tokens=unknown plan=max

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant