You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Head SHA: 9dfd70db15f38829b3d7f7edaa3151d9483a1298 Base: origin/main Verdict: CHANGES REQUESTED Score: 3/10
Executive Summary
PR #51 attempts to bump upstream versions in versions.env (serialize 1.16.0, reliable 1.4.2, netcode 1.4.5, yojimbo 1.12.1, schema 2.4.0). While git 3-way mergeability against origin/main is clean, this PR cannot be merged in its current state for two critical reasons:
Packaging Breakage & CI Failure: In remote CI run 34107867178 on exact head commit 9dfd70db15f38829b3d7f7edaa3151d9483a1298, all 10 matrix builds failed when compiling yojimbo. Upstream yojimbo v1.12.1 changed its CMake runtime output directory from ${CMAKE_CURRENT_SOURCE_DIR}/bin to ${CMAKE_BINARY_DIR}/bin (and added native CTest support). As a result, packages/yojimbo/debian/rules (and official/yojimbo/debian/rules) hardcoding $(CURDIR)/bin/test fails with:
make[1]: /__w/apt/apt/build/yojimbo/yojimbo-1.12.1/bin/test: No such file or directory
make[1]: *** [debian/rules:20: override_dh_auto_test] Error 127
Stale Upstream Versions: The PR was generated 14 days ago and is already superseded by newer upstream releases across all 5 packages.
All pinned versions in PR #51 are already behind the latest upstream releases.
4. Negative Control / Red-Test
Verified the sensitivity of ./scripts/check-releases.sh:
Positive Control: Temporarily set versions.env to current latest upstream versions -> all pinned versions are current, Exit Code: 0.
Negative Control: Mutated SERIALIZE_VERSION=9.9.9 -> serialize: pinned 9.9.9, latest 1.17.0, Exit Code: 1.
The verification script reliably discriminates between matching and non-matching versions.
5. Remote CI Build Implications & Root Cause Analysis
Inspected workflow run 34107867178 triggered on head commit 9dfd70db15f38829b3d7f7edaa3151d9483a1298:
autopkgtest-schema: Passed (51s).
Matrix build jobs across all 10 environments (Debian 12/13, Ubuntu 22.04/24.04/26.04 on amd64/arm64): Failed with exit code 2.
Log error:
debian/rules override_dh_auto_test
make[1]: /__w/apt/apt/build/yojimbo/yojimbo-1.12.1/bin/test: No such file or directory
make[1]: *** [debian/rules:20: override_dh_auto_test] Error 127
make: *** [debian/rules:7: binary] Error 2
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2
Root Cause: Upstream yojimbo commit for v1.12.0/v1.12.1 updated CMakeLists.txt to set CMAKE_RUNTIME_OUTPUT_DIRECTORY to ${CMAKE_BINARY_DIR}/bin and integrated ctest. The Debian package rules in packages/yojimbo/debian/rules and official/yojimbo/debian/rules still expect the binary at $(CURDIR)/bin/test.
Required Actions Before Merging
Update packages/yojimbo/debian/rules (and official/yojimbo/debian/rules) to properly locate the test executable under the build directory or rely on dh_auto_test (using CTest).
Re-run ./scripts/check-releases.sh --update to bump all packages to their latest upstream versions (serialize 1.17.0, reliable 1.4.5, netcode 1.4.8, yojimbo 1.13.5, schema 2.5.0).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated bump from check-releases.yml. Merging rebuilds and republishes the apt repository.