Skip to content

Bump package versions to latest upstream releases - #53

Open
github-actions[bot] wants to merge 1 commit into
mainfrom
bump-versions-20260909
Open

github-actions[bot] wants to merge 1 commit into
mainfrom
bump-versions-20260909

Conversation

@github-actions

@github-actions github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Automated bump from check-releases.yml. Merging rebuilds and republishes the apt repository.

@gafferongames

Copy link
Copy Markdown
Contributor

Review of PR #53: Bump package versions to latest upstream releases

  • Head SHA: 74d3719c32b1827780a3c80c55c5f6f810464540 (branch: bump-versions-20260909)
  • Base: origin/main (8ba166a51f3a0d7761d73f3e64d285f3c8ab256d)
  • Reviewer: Emma Antigravity (gemini-2.5-pro)
  • Score: 3/10
  • Verdict: CHANGES REQUESTED

Executive Summary

While the PR cleanly merges against origin/main at the git tree level, the automated package build fails 100% of its matrix builds in CI, and the pinned versions are already out of date relative to current upstream releases.

Specifically, upstream yojimbo changed its CMake executable output directory from the source root (${CMAKE_CURRENT_SOURCE_DIR}/bin) to the build directory (${CMAKE_BINARY_DIR}/bin) in release v1.13.0. This change breaks packages/yojimbo/debian/rules (override_dh_auto_test), causing every distro container build to abort with Error 127: /__w/apt/apt/build/yojimbo/yojimbo-1.13.0/bin/test: No such file or directory. In addition, since this PR was created 12 days ago, new upstream releases have shipped for reliable (1.4.5), netcode (1.4.8), and yojimbo (1.13.5).


Verification Evidence

1. 3-Way Merge Verification

Executed git merge-tree write test against origin/main:

git merge-tree --write-tree origin/main 74d3719c32b1827780a3c80c55c5f6f810464540
  • Exit Code: 0 (Success)
  • Result Tree SHA: c4bbd7dd950d112a827b96e39ab114aed1594c49
  • 74d3719c32b1827780a3c80c55c5f6f810464540 is a direct descendant (fast-forward) from origin/main (8ba166a51f3a0d7761d73f3e64d285f3c8ab256d).

2. Diff Against Base (versions.env)

Single file changed (versions.env):

-SERIALIZE_VERSION=1.15.0
-RELIABLE_VERSION=1.4.0
-NETCODE_VERSION=1.4.3
-YOJIMBO_VERSION=1.10.1
-SCHEMA_VERSION=2.0.0
+SERIALIZE_VERSION=1.17.0
+RELIABLE_VERSION=1.4.2
+NETCODE_VERSION=1.4.5
+YOJIMBO_VERSION=1.13.0
+SCHEMA_VERSION=2.5.0

3. Upstream Currency Verification (./scripts/check-releases.sh)

Running ./scripts/check-releases.sh produced:

reliable: pinned 1.4.2, latest 1.4.5
netcode: pinned 1.4.5, latest 1.4.8
yojimbo: pinned 1.13.0, latest 1.13.5
  • Exit Code: 1
  • The PR is superseded by subsequent releases in three out of five packages.

4. Remote CI Build Results and Implications

Inspected GitHub Actions run 34334998471 (workflow: build.yml, trigger: workflow_dispatch on bump-versions-20260909 for commit 74d3719c32b1827780a3c80c55c5f6f810464540):

  • autopkgtest-schema: Passed (1m 31s)
  • All 10 matrix build jobs (debian:12, debian:13, ubuntu:22.04, ubuntu:24.04, ubuntu:26.04 on both amd64 and arm64) FAILED:
    debian/rules override_dh_auto_test
    make[1]: /__w/apt/apt/build/yojimbo/yojimbo-1.13.0/bin/test: No such file or directory
    make[1]: *** [debian/rules:20: override_dh_auto_test] Error 127
    make: *** [debian/rules:7: binary] Error 2
    dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2
    
  • Root Cause Analysis:
    • In yojimbo v1.10.1, CMakeLists.txt set CMAKE_RUNTIME_OUTPUT_DIRECTORY to ${CMAKE_CURRENT_SOURCE_DIR}/bin.
    • In yojimbo v1.13.0, upstream changed output to ${CMAKE_BINARY_DIR}/bin and enabled CTest registration.
    • packages/yojimbo/debian/rules lines 18–21 invoke $(CURDIR)/bin/test assuming the binary is in the source tree root, which fails.
    • Merging this PR to main would trigger build.yml, fail on all distros, and prevent repository deployment to GitHub Pages.

5. Negative Control / Red-Test (Sensitivity Verification)

  1. Mutation sensitivity: Mutated SERIALIZE_VERSION in versions.env from 1.17.0 to 1.16.0. ./scripts/check-releases.sh immediately caught the discrepancy (serialize: pinned 1.16.0, latest 1.17.0) and exited with status 1.
  2. Clean state verification: Running ./scripts/check-releases.sh --update updated versions.env to current upstream versions (1.4.5, 1.4.8, 1.13.5), after which ./scripts/check-releases.sh printed all pinned versions are current and exited with status 0.
  3. Restored worktree cleanly to 74d3719c32b1827780a3c80c55c5f6f810464540.

Required Actions Before Merging

  1. Update packages/yojimbo/debian/rules to run tests via dh_auto_test (utilizing CTest) or locate the test executable under the build tree (obj-*/bin/test).
  2. Re-bump versions in versions.env to the current upstream releases (reliable 1.4.5, netcode 1.4.8, yojimbo 1.13.5).
  3. Ensure CI passes cleanly across the entire distro matrix before landing.

READ-COST: reader=Emma model=gemini-2.5-pro seconds=315 tokens=unknown plan=max

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant