Skip to content

Bump package versions to latest upstream releases - #55

Open
github-actions[bot] wants to merge 1 commit into
mainfrom
bump-versions-20260911
Open

github-actions[bot] wants to merge 1 commit into
mainfrom
bump-versions-20260911

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Automated bump from check-releases.yml. Merging rebuilds and republishes the apt repository.

@gafferongames

Copy link
Copy Markdown
Contributor

Review for PR #55: Bump package versions to latest upstream releases

  • Repository: mas-bandwidth/apt
  • Head SHA: 266a6df3c8db057814720821788d7859c2d1a6f1 (branch: bump-versions-20260911)
  • Base: origin/main
  • Score: 3/10
  • Verdict: CHANGES REQUESTED

Executive Summary

While the git 3-way merge against origin/main succeeds cleanly without textual conflicts (23f220c034d90aeed306ebfdcf18470fd04a1871), this PR cannot be merged in its current state due to two blocking issues:

  1. Broken CI Build (Packaging Bug): The automated workflow build (Run 34584388605) failed on all 10 matrix combinations (debian:12, debian:13, ubuntu:22.04, ubuntu:24.04, ubuntu:26.04 on both amd64 and arm64). In upstream Yojimbo 1.13.1, the build system transitioned from Premake to CMake, outputting test binaries to ${CMAKE_BINARY_DIR}/bin/ rather than the source root. Consequently, packages/yojimbo/debian/rules:20 hardcoding $(CURDIR)/bin/test fails with No such file or directory (Error 127).
  2. Stale Upstream Versions: The PR branch was generated on 2026-09-11. In the intervening 10 days, several upstream libraries have published subsequent releases:
    • reliable: 1.4.3 → 1.4.5
    • netcode: 1.4.6 → 1.4.8
    • yojimbo: 1.13.1 → 1.13.5

Detailed Verification Evidence

1. 3-Way Merge Verification

git merge-tree --write-tree origin/main 266a6df3c8db057814720821788d7859c2d1a6f1
  • Tree SHA: 23f220c034d90aeed306ebfdcf18470fd04a1871
  • Exit code: 0 (Clean merge, no merge conflicts against base origin/main).

2. Diff Inspection (versions.env)

diff --git a/versions.env b/versions.env
index 59a504c..5d0b3b4 100644
--- a/versions.env
+++ b/versions.env
@@ -1,10 +1,10 @@
 # Pinned upstream versions built and published by CI.
 # check-releases.yml compares these against the latest GitHub releases daily.
-SERIALIZE_VERSION=1.15.0
-RELIABLE_VERSION=1.4.0
-NETCODE_VERSION=1.4.3
-YOJIMBO_VERSION=1.10.1
-SCHEMA_VERSION=2.0.0
+SERIALIZE_VERSION=1.17.0
+RELIABLE_VERSION=1.4.3
+NETCODE_VERSION=1.4.6
+YOJIMBO_VERSION=1.13.1
+SCHEMA_VERSION=2.5.0

3. Release Freshness Check (./scripts/check-releases.sh)

Execution in isolated scratch worktree against head 266a6df3c8db057814720821788d7859c2d1a6f1:

$ ./scripts/check-releases.sh
reliable: pinned 1.4.3, latest 1.4.5
netcode: pinned 1.4.6, latest 1.4.8
yojimbo: pinned 1.13.1, latest 1.13.5
[Exit code: 1]

serialize (1.17.0) and schema (2.5.0) are current, but the other three dependencies have advanced upstream.

4. Remote CI Results & Root Cause Analysis

  • CI Run: Workflow run 34584388605 (build.yml)
  • Status: Failed (all 10 matrix targets failed during build all packages).
  • Failure Log Excerpt (from Debian 13 amd64 job 103215113249):
       debian/rules override_dh_auto_test
    make[1]: Entering directory '/__w/apt/apt/build/yojimbo/yojimbo-1.13.1'
    /__w/apt/apt/build/yojimbo/yojimbo-1.13.1/bin/test
    make[1]: /__w/apt/apt/build/yojimbo/yojimbo-1.13.1/bin/test: No such file or directory
    make[1]: *** [debian/rules:20: override_dh_auto_test] Error 127
    make: *** [debian/rules:7: binary] Error 2
    dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2
    
  • Root Cause: packages/yojimbo/debian/rules contains:
    # yojimbo has no ctest wiring; run its test binary directly (executables
    # are written to bin/ at the source root). Must print "ALL TESTS PASS".
    override_dh_auto_test:
    ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS)))
    	$(CURDIR)/bin/test
    endif
    With Yojimbo 1.13.1's new CMake build system, CTest support was introduced (enable_testing(), add_test(NAME yojimbo_test COMMAND yojimbo_test)), and binaries are compiled to ${CMAKE_BINARY_DIR}/bin/test (e.g., obj-$(DEB_HOST_GNU_TYPE)/bin/test). Running $(CURDIR)/bin/test attempts to execute a non-existent binary in the source root.

5. Controls & Sensitivity Verification (Red & Green Tests)

  • Negative Control (Red Test):
    Mutated SERIALIZE_VERSION in versions.env from 1.17.0 to 0.0.1. Executing ./scripts/check-releases.sh produced:
    serialize: pinned 0.0.1, latest 1.17.0
    reliable: pinned 1.4.3, latest 1.4.5
    netcode: pinned 1.4.6, latest 1.4.8
    yojimbo: pinned 1.13.1, latest 1.13.5
    [Exit code: 1]
    
    This confirms that check-releases.sh accurately catches mismatched / outdated versions.
  • Positive Control (Green Test):
    Running ./scripts/check-releases.sh --update updated versions.env to current upstream releases (reliable=1.4.5, netcode=1.4.8, yojimbo=1.13.5). Subsequent execution of ./scripts/check-releases.sh returned:
    all pinned versions are current
    [Exit code: 0]
    

Required Action Items

  1. Fix packages/yojimbo/debian/rules:
    Remove or update the override_dh_auto_test block to allow dh_auto_test to run upstream's CTest suite, matching the packaging pattern used in packages/reliable/debian/rules.
  2. Re-bump versions.env:
    Update versions.env to the latest upstream tags (reliable=1.4.5, netcode=1.4.8, yojimbo=1.13.5) and re-trigger build.yml.

READ-COST: reader=Emma model=gemini-2.5-pro seconds=152 tokens=unknown plan=max

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant