Skip to content

Bump package versions to latest upstream releases - #56

Open
github-actions[bot] wants to merge 1 commit into
mainfrom
bump-versions-20260912
Open

github-actions[bot] wants to merge 1 commit into
mainfrom
bump-versions-20260912

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Automated bump from check-releases.yml. Merging rebuilds and republishes the apt repository.

@gafferongames

Copy link
Copy Markdown
Contributor

Review of PR #56 (bump-versions-20260912)

  • Target Commit (Head SHA): 711e560a8150fad580cb841f24daabeacc6e2b97
  • Base: origin/main (8ba166a51f3a0d7761d73f3e64d285f3c8ab256d)
  • Verdict: CHANGES REQUESTED
  • Score: 3/10

Summary of Changes

The PR bumps upstream pinned versions in versions.env:

  • SERIALIZE_VERSION: 1.15.0 → 1.17.0
  • RELIABLE_VERSION: 1.4.0 → 1.4.3
  • NETCODE_VERSION: 1.4.3 → 1.4.6
  • YOJIMBO_VERSION: 1.10.1 → 1.13.1
  • SCHEMA_VERSION: 2.0.0 → 2.5.0

Verification Evidence

1. 3-Way Merge Simulation

Tested 3-way merge against origin/main using git merge-tree:

git merge-tree --write-tree origin/main 711e560a8150fad580cb841f24daabeacc6e2b97
  • Exit code: 0
  • Result tree: 23f220c034d90aeed306ebfdcf18470fd04a1871 (clean merge, no git conflicts).

2. CI Build Investigation (BLOCKER)

Inspecting the automated CI workflow runs triggered on branch bump-versions-20260912 (run ID 34685782459):

  • Status: FAILED across all 10 matrix builds (debian:12, debian:13, ubuntu:22.04, ubuntu:24.04, ubuntu:26.04 on both amd64 and arm64).
  • Failure Point: Step 6 (build all packages), specifically during package build for yojimbo:
    debian/rules override_dh_auto_test
    make[1]: Entering directory '/__w/apt/apt/build/yojimbo/yojimbo-1.13.1'
    make[1]: /__w/apt/apt/build/yojimbo/yojimbo-1.13.1/bin/test: No such file or directory
    make[1]: *** [debian/rules:20: override_dh_auto_test] Error 127
    make[1]: Leaving directory '/__w/apt/apt/build/yojimbo/yojimbo-1.13.1'
    make: *** [debian/rules:7: binary] Error 2
    dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2
    
  • Root Cause:
    In upstream yojimbo v1.13.1, executables are built into the CMake build tree (<build>/bin/) rather than the source root (bin/), and upstream registered the test suite with CTest (enable_testing(), add_test(NAME yojimbo_test COMMAND yojimbo_test)).
    packages/yojimbo/debian/rules contains a legacy override:
    override_dh_auto_test:
    ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS)))
    	$(CURDIR)/bin/test
    endif
    This hardcoded path $(CURDIR)/bin/test no longer exists, breaking dpkg-buildpackage. Merging this PR in its current state would break repository builds on main.

3. Upstream Releases Staleness Check

Running ./scripts/check-releases.sh against the PR commit:

$ ./scripts/check-releases.sh
reliable: pinned 1.4.3, latest 1.4.5
netcode: pinned 1.4.6, latest 1.4.8
yojimbo: pinned 1.13.1, latest 1.13.5
Exit code: 1

Since PR #56 was created on 2026-09-12, new releases have shipped for reliable (1.4.5), netcode (1.4.8), and yojimbo (1.13.5). The versions proposed here are already stale.


4. Negative and Positive Controls

  • Negative Control:
    Mutated SCHEMA_VERSION=2.4.99 in versions.env.
    Ran ./scripts/check-releases.sh: detected schema: pinned 2.4.99, latest 2.5.0 and exited 1.
  • Positive Control:
    Updated versions.env to current upstream releases (1.17.0, 1.4.5, 1.4.8, 1.13.5, 2.5.0).
    Ran ./scripts/check-releases.sh: reported all pinned versions are current and exited 0.

Required Actions Before Merging

  1. Update packages/yojimbo/debian/rules to remove override_dh_auto_test (or adapt it to CTest / build-dir paths) so that dh_auto_test succeeds with modern Yojimbo releases.
  2. Run ./scripts/check-releases.sh --update to refresh versions.env to the current upstream release set (reliable 1.4.5, netcode 1.4.8, yojimbo 1.13.5).
  3. Re-run build.yml on the branch to confirm package builds pass across all target distros.

READ-COST: reader=Emma model=gemini-2.5-pro seconds=145 tokens=unknown plan=max

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant