Skip to content

Bump package versions to latest upstream releases - #58

Open
github-actions[bot] wants to merge 1 commit into
mainfrom
bump-versions-20260914
Open

github-actions[bot] wants to merge 1 commit into
mainfrom
bump-versions-20260914

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Automated bump from check-releases.yml. Merging rebuilds and republishes the apt repository.

@gafferongames

Copy link
Copy Markdown
Contributor

Review of PR #58: Bump package versions to latest upstream releases

Head SHA: 9094551ded27cd7745a5d7ddb071aa598997041e
Base: origin/main
Score: 3/10
Verdict: CHANGES REQUESTED (HOLD merge)


Summary of Changes

The PR bumps pinned upstream package versions in versions.env:

  • SERIALIZE_VERSION: 1.15.0 -> 1.17.0
  • RELIABLE_VERSION: 1.4.0 -> 1.4.5
  • NETCODE_VERSION: 1.4.3 -> 1.4.8
  • YOJIMBO_VERSION: 1.10.1 -> 1.13.5
  • SCHEMA_VERSION: 2.0.0 -> 2.5.0

Verification Evidence

  1. 3-Way Merge Verification:

    • Ran: git merge-tree --write-tree origin/main 9094551ded27cd7745a5d7ddb071aa598997041e
    • Output tree: b29a89813c730f307eb547db1f51834460e5bb6f (Exit code: 0).
    • Git tree merges cleanly with origin/main without conflicts.
  2. Release Check Script:

    • Ran ./scripts/check-releases.sh in isolated worktree tracking 9094551ded27cd7745a5d7ddb071aa598997041e.
    • Result: all pinned versions are current (Exit code: 0). The pinned tags match the latest releases on GitHub.
  3. Negative Control / Red-Test (Script Sensitivity):

    • Temporarily mutated SERIALIZE_VERSION=0.0.1 in versions.env.
    • Result: ./scripts/check-releases.sh caught the stale version (serialize: pinned 0.0.1, latest 1.17.0) and exited with code 1.
    • Restored versions.env to clean state.
  4. CI Build Implications & Remote Failure Analysis:

    • Inspected GitHub Actions workflow run 34828773120 (build.yml triggered on branch bump-versions-20260914 at commit 9094551ded27cd7745a5d7ddb071aa598997041e).
    • Result: ALL 10 matrix build targets (ubuntu:22.04, ubuntu:24.04, ubuntu:26.04, debian:12, debian:13 on amd64 and arm64) failed at step build all packages with exit code 2.
    • Root Cause:
      packages/yojimbo/debian/rules (lines 18–21) defines:
      # yojimbo has no ctest wiring; run its test binary directly (executables
      # are written to bin/ at the source root). Must print "ALL TESTS PASS".
      override_dh_auto_test:
      ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS)))
      	$(CURDIR)/bin/test
      endif
      In upstream yojimbo between v1.10.1 and v1.13.5:
      • CMAKE_RUNTIME_OUTPUT_DIRECTORY (which previously routed compiled binaries to ${CMAKE_CURRENT_SOURCE_DIR}/bin) was removed in favor of standard build directories (obj-<triplet>/bin/test).
      • Upstream added full CTest integration (enable_testing(), add_test(NAME yojimbo_test COMMAND yojimbo_test)).
      • Because override_dh_auto_test still hardcodes $(CURDIR)/bin/test, dpkg-buildpackage fails across all distros with:
        make[1]: /__w/apt/apt/build/yojimbo/yojimbo-1.13.5/bin/test: No such file or directory
        make[1]: *** [debian/rules:20: override_dh_auto_test] Error 127
        
      • Note: official/yojimbo/debian/rules contains the same override and will experience the same failure.

Required Action

Merging this PR as-is will break the main CI build and prevent packaging and publication of the apt repository.

Before merging:

  1. Update packages/yojimbo/debian/rules (and official/yojimbo/debian/rules) to adapt to Yojimbo 1.13.5's CMake layout (e.g. remove override_dh_auto_test so CMake's default dh_auto_test / CTest runner is used, or update the path to the test executable).
  2. Re-trigger and verify a green build.yml CI run on the branch before merging.

READ-COST: reader=Emma model=gemini-2.5-pro seconds=170 tokens=unknown plan=max

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant