Skip to content

Bump package versions to latest upstream releases - #60

Open
github-actions[bot] wants to merge 1 commit into
mainfrom
bump-versions-20260916
Open

github-actions[bot] wants to merge 1 commit into
mainfrom
bump-versions-20260916

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Automated bump from check-releases.yml. Merging rebuilds and republishes the apt repository.

@gafferongames

Copy link
Copy Markdown
Contributor

Review: PR #60 (mas-bandwidth/apt)

  • Head SHA: 3579f4981026d9b87486bf64afcbb1eabf38308e
  • Branch: bump-versions-20260916
  • Base: origin/main
  • Score: 5/10
  • Verdict: HOLD

Summary & Assessment

PR #60 is an automated daily version bump generated by check-releases.yml against versions.env. While the version strings correctly reflect the latest upstream releases and merge cleanly with zero git conflicts, merging this PR in its current state will break CI and package publication on main.

Upstream mas-bandwidth/yojimbo v1.13.5 relocated its CMake runtime output directory from the source tree to the CMake binary build directory, breaking packages/yojimbo/debian/rules during package build across all 10 distro/architecture matrix runners.


Verification Evidence

1. 3-Way Mergeability Verification

  • Ran:
    git merge-tree --write-tree origin/main 3579f4981026d9b87486bf64afcbb1eabf38308e
  • Result:
    • Tree SHA: b29a89813c730f307eb547db1f51834460e5bb6f
    • Exit code: 0 (clean merge against base, no conflicts)

2. Upstream Release Verification (check-releases.sh)

  • Pinned changes in versions.env:
    • SERIALIZE_VERSION: 1.15.0 → 1.17.0
    • RELIABLE_VERSION: 1.4.0 → 1.4.5
    • NETCODE_VERSION: 1.4.3 → 1.4.8
    • YOJIMBO_VERSION: 1.10.1 → 1.13.5
    • SCHEMA_VERSION: 2.0.0 → 2.5.0
  • Ran:
    ./scripts/check-releases.sh
  • Result:
    all pinned versions are current
    
    Exit code: 0. All 5 repositories match the latest tagged releases on GitHub.

3. Negative Control / Red-Test (Sensitivity Check)

  • Mutated versions.env locally (SERIALIZE_VERSION=1.15.0).
  • Ran ./scripts/check-releases.sh:
    • Output: serialize: pinned 1.15.0, latest 1.17.0
    • Exit code: 1
  • Confirmed that ./scripts/check-releases.sh detects version discrepancies properly and exits non-zero. Restored working tree cleanly afterwards.

4. CI Build & Remote Run Analysis

  • Inspected remote GitHub Actions runs on branch bump-versions-20260916:
    • build.yml via workflow_dispatch (Run ID: 35079625881, commit 3579f4981026d9b87486bf64afcbb1eabf38308e):
      • autopkgtest-schema: Passed (1m1s)
      • build matrix (ubuntu:22.04, ubuntu:24.04, ubuntu:26.04, debian:12, debian:13 on amd64 and arm64): Failed on all 10 targets.
  • Failure traceback across all containers:
    make[1]: /__w/apt/apt/build/yojimbo/yojimbo-1.13.5/bin/test: No such file or directory
    make[1]: Entering directory '/__w/apt/apt/build/yojimbo/yojimbo-1.13.5'
    make[1]: *** [debian/rules:20: override_dh_auto_test] Error 127
    make[1]: Leaving directory '/__w/apt/apt/build/yojimbo/yojimbo-1.13.5'
    make: *** [debian/rules:7: binary] Error 2
    dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2
    

5. Root Cause Analysis

  • In upstream mas-bandwidth/yojimbo v1.10.1 CMakeLists.txt:
    set(CMAKE_RUNTIME_OUTPUT_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}/bin")
  • In upstream mas-bandwidth/yojimbo v1.13.5 CMakeLists.txt:
    set(CMAKE_RUNTIME_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/bin")
  • packages/yojimbo/debian/rules lines 18-21:
    # yojimbo has no ctest wiring; run its test binary directly (executables
    # are written to bin/ at the source root). Must print "ALL TESTS PASS".
    override_dh_auto_test:
    ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS)))
    	$(CURDIR)/bin/test
    endif
    Because debhelper (dh $@ --buildsystem=cmake) builds out-of-source in obj-<architecture>/, bin/test is now output to obj-*/bin/test instead of $(CURDIR)/bin/test. When override_dh_auto_test executes $(CURDIR)/bin/test, it fails with No such file or directory (Error 127).

Action Items Before Merge

  1. Update packages/yojimbo/debian/rules so override_dh_auto_test executes test from the CMake binary directory (e.g. searching or running under obj-*/bin/test or wiring into dh_auto_test).
  2. Re-trigger build.yml once debian/rules is patched to ensure full 10-runner matrix build and smoke tests pass.

READ-COST: reader=Emma model=gemini-2.5-pro seconds=151 tokens=unknown plan=max

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant