Skip to content

Bump package versions to latest upstream releases - #62

Open
github-actions[bot] wants to merge 1 commit into
mainfrom
bump-versions-20260918
Open

github-actions[bot] wants to merge 1 commit into
mainfrom
bump-versions-20260918

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Automated bump from check-releases.yml. Merging rebuilds and republishes the apt repository.

@gafferongames

Copy link
Copy Markdown
Contributor

Review of PR #62: Bump package versions to latest upstream releases

Head SHA: 8e2dad3ae781f50608cc0dd92997c50a5c999952
Base: origin/main (8ba166a51f3a0d7761d73f3e64d285f3c8ab256d)
Score: 4/10
Verdict: HOLD (Packaging fixes required before merge)


Executive Summary

PR #62 correctly identifies and pins the newest upstream releases for the mas-bandwidth suite (serialize 1.17.0, reliable 1.4.5, netcode 1.4.8, yojimbo 1.13.5, and schema 2.5.0). The 3-way merge is clean and upstream versions are verified against GitHub releases.

However, remote CI fails on all 10 matrix build targets (Run ID 35329700831). Upstream Yojimbo 1.13.5 (specifically commit YJ-06) relocated test binaries into CMake's build tree (${CMAKE_BINARY_DIR}/bin) rather than the source root. Because packages/yojimbo/debian/rules expects $(CURDIR)/bin/test, package compilation fails during override_dh_auto_test with No such file or directory (exit code 127).

Merging this PR in its current state will break apt packaging and deployment across all supported Debian and Ubuntu distributions.


Verification Evidence

1. 3-Way Merge Test

  • Verified 3-way merge against origin/main using git merge-tree:
    git merge-tree --write-tree origin/main 8e2dad3ae781f50608cc0dd92997c50a5c999952
  • Result: Clean merge, exit code 0.
  • Merge tree: b29a89813c730f307eb547db1f51834460e5bb6f.

2. Release Currency Verification

  • Ran ./scripts/check-releases.sh against the checked-out PR:
    $ ./scripts/check-releases.sh
    all pinned versions are current
  • All 5 version bumps in versions.env accurately match the latest releases published across mas-bandwidth/*.

3. Negative Control / Red-Test

  • Mutated versions.env locally (SERIALIZE_VERSION=1.16.0 instead of 1.17.0) to verify ./scripts/check-releases.sh sensitivity:
    $ ./scripts/check-releases.sh
    serialize: pinned 1.16.0, latest 1.17.0
    # exit code: 1
  • Confirmed that the check script reliably fails when a pinned version is stale.

4. Remote CI & Root Cause Analysis

  • Remote CI run 35329700831 failed across all 10 matrix configurations:
    • debian:12 (amd64, arm64)
    • debian:13 (amd64, arm64)
    • ubuntu:22.04 (amd64, arm64)
    • ubuntu:24.04 (amd64, arm64)
    • ubuntu:26.04 (amd64, arm64)
      (Note: autopkgtest-schema succeeded, confirming schema 2.5.0 passes test).
  • Inspection of failed job logs (Ubuntu 22.04 amd64, Job 105550951218) revealed:
    debian/rules override_dh_auto_test
    make[1]: Entering directory '/__w/apt/apt/build/yojimbo/yojimbo-1.13.5'
    /__w/apt/apt/build/yojimbo/yojimbo-1.13.5/bin/test
    make[1]: /__w/apt/apt/build/yojimbo/yojimbo-1.13.5/bin/test: No such file or directory
    make[1]: *** [debian/rules:20: override_dh_auto_test] Error 127
    make[1]: Leaving directory '/__w/apt/apt/build/yojimbo/yojimbo-1.13.5'
    make: *** [debian/rules:7: binary] Error 2
    dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2
    
  • Upstream Root Cause:
    In Yojimbo 1.13.5, CMakeLists.txt lines 71–76 now set:
    set(CMAKE_RUNTIME_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/bin")
    In Debian packaging using dh $@ --buildsystem=cmake, the build directory is obj-$(DEB_HOST_GNU_TYPE)/ (out-of-source), whereas packages/yojimbo/debian/rules line 20 executes $(CURDIR)/bin/test.
    (The same rules structure exists in official/yojimbo/debian/rules).

Required Action Items

  1. Update packages/yojimbo/debian/rules (and sync official/yojimbo/debian/rules) so override_dh_auto_test locates bin/test in the cmake build directory (e.g. obj-*/bin/test) rather than $(CURDIR).
  2. Push the packaging fix or re-run the build workflow to verify that all 10 matrix jobs and publishing succeed.

READ-COST: reader=Emma model=gemini-2.5-pro seconds=166 tokens=unknown plan=max

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant