Bump docfx to 2.81.0 - #11
Merged
Merged
Conversation
Dependabot's update (#7) drops the final newline from .config/dotnet-tools.json, which .editorconfig requires, so the bump is made here with the newline kept. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by masa · project thread
What this changes
Before: docfx is pinned to 2.80.1. Dependabot's update to 2.81.0 (#7, rewritten after #10 landed) again drops the final newline from
.config/dotnet-tools.json, which.editorconfig(insert_final_newline = true) requires.After: docfx is pinned to 2.81.0 and the file keeps its final newline. This replaces #7; Dependabot closes it once main carries 2.81.0.
How: a one-line version change. PR CI does not run docfx (the Docs workflow runs on pushes to main only), so the site was built locally from main with 2.80.1 and with 2.81.0 and compared: both exit 0, the same 9 warnings, and every generated page is byte-identical. The only differences are the template's rebuilt JS bundles under
public/and a newdocfx_versionfield inmanifest.json. The 2.81.0 upgrade note (a timeout for custom JavaScript template preprocessors) does not apply:docfx/docfx.jsonuses only the built-indefaultandmoderntemplates.Checklist
The long form of each gate is in
CONTRIBUTING.md.dotnet buildis warning-free. Not affected: only the docfx tool pin changes; CI covers the build.verifycovers it.src/*/Generated/was hand-edited.dotnet testpasses. Not run locally (no project code changes); left to the CI matrix.🤖 Generated with Claude Code
https://claude.ai/code/session_01AxJrKQ3nzaSxVXcYzZkVu3
Generated by Claude Code