Repository navigation
CI(Release): Check editor versions only when the push releases - #502
Merged
Merged
Conversation
The editor version gate ran whenever a push affected the VS Code extension, so a push without release commits failed on an editor version that an earlier release had already published, before scripts/release.mjs could report that nothing releases. A plan step, `release.mjs --dry-run --github-output`, now writes the planned version, and the gate runs only when there is one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The first Release run after #501 (run 42331744292) failed in Require unused editor versions before publishing npm: the gate runs whenever validation reports
vscode_release_affected, so a push without release commits failed on editor version 2.0.37, which v2.0.3 already published, beforescripts/release.mjscould report that nothing releases.node scripts/release.mjs --dry-run --github-output, which writesrelease,versionandtagto$GITHUB_OUTPUTwithout verifying, packing or writing anything.steps.plan.outputs.version != ''.publish-editorsalready requiresreleased == 'true'.Validation
scripts/release.test.mjs(new dry-run output test),scripts/editor-release-gate.test.mjs(plan → gate → release order and condition),scripts/validation-workflow.test.mjs,bun run check:releasepass locally.node scripts/release.mjs --dry-run --github-output --branch mainon this branch writes an empty version: v2.0.3..HEAD has no release commits.🤖 Generated with Claude Code