Repository navigation
Build(Rust): Restore unchanged Wasm artifacts from the Turbo cache - #505
Merged
Merged
Conversation
build:rust:wasm called cargo xtask build-wasm directly, bypassing the cached build:artifacts tasks. Every CI job therefore spent about 3.5 minutes recompiling the Wasm bindings, after which Turbo replayed its cached outputs over them anyway. Running the same tasks through Turbo compiles only when crates, Cargo or the toolchain change and restores byte-identical artifacts otherwise. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Each engine walked its 68 profiles one by one, mostly waiting for network idle, fonts and axe. A small pool per engine (--concurrency, default 2) overlaps that waiting; on efficiency cores the run dropped from 198s to 133s. Entries are sorted by their place in the profile matrix, so the report is identical to the sequential one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The site build already runs audit:i18n before rendering pages. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
On a runner without the pinned toolchain, the three cargo xtask tasks
started together and each made rustup auto-install it, racing on the
same download files ("could not rename 'downloaded' file"). Cargo's
build lock already serializes the compiles, so one task at a time costs
nothing and lets the first install the toolchain for the rest.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…owser" This reverts commit ea018df. On the 4-vCPU CI runner the three browsers already saturate the CPU: two pages per engine shortened verification only from 414s to 394s, and the extra load made a networkidle navigation time out. The local measurement on efficiency cores did not represent CI. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
quality-linuxjob takes about 22.6 minutes (example run). This is caused by how CI is set up, not by outdated dependencies (Astro 7.4, Vite 8.3, Playwright 1.64 and Turbo 2.11 are all current). One avoidable cost: every job compiled the Rust Wasm bindings from scratch (~3.5 min on Linux, ~5 min on macOS). Turbo then replayed its cached outputs over them anyway.Changes
build:rust:wasmnow runs the cached Turbobuild:artifactstasks instead of callingcargo xtask build-wasm alldirectly. It compiles only when crates, Cargo or the toolchain change. Locally: cold 61s, cached 48ms, and the artifacts are byte-identical to the direct xtask build. This applies to quality-linux, e2e-linux, compat-*, the release build and deploy-site.could not rename 'downloaded' file). The failure is reproduced locally with an emptyRUSTUP_HOME. Cargo's build lock already serializes the compiles, so running them one at a time costs nothing.audit:i18n, becausesite buildalready runs it.Tried and reverted
Checking two release-site profiles at a time per browser cut verification from 198s to 133s on local efficiency cores. On the 4-vCPU runner the three browsers already use the whole CPU: it only went from 414s to 394s, and one
networkidlenavigation timed out. Reverted.Note
This PR's own runs missed the Turbo cache for Wasm, so they still compile it. Pull requests restore the cache but never save it, so the saving shows up on main after a push has saved a cache entry for these task hashes.
🤖 Generated with Claude Code