SOF-7926 - #408
Open
k0stik wants to merge 20 commits into
Open
Conversation
Extract hash into a reusable hashed schema and compose bankable from hashed plus exabyteId. Co-authored-by: Cursor <cursoragent@cursor.com>
Compose hash via system/hashed at consumer schemas instead of allOf in bankable. Co-authored-by: Cursor <cursoragent@cursor.com>
timurbazhirov
approved these changes
Jun 23, 2026
Material entities now compose system/hashed.json alongside named/defaultable in-memory mixins so MaterialSchema includes the persisted hash field. Co-authored-by: Cursor <cursoragent@cursor.com>
name and status are already provided via named_defaultable and status refs in workflow/unit/base.json; removing them from mixins/base avoids duplicate getters in generated schema mixins. Co-authored-by: Cursor <cursoragent@cursor.com>
unit-specific mixins already declare literal type values; keeping type off the shared base mixin avoids TS interface merge conflicts in wode. Co-authored-by: Cursor <cursoragent@cursor.com>
Remove required hash from material.json and add material_hashed.json composing material + system/hashed for persisted hashed entities. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
| } | ||
| }, | ||
| "required": [ | ||
| "type", |
Member
There was a problem hiding this comment.
We should keep this base "as is"
Introduce basis_constrained so materials can require atomic constraints on basis, and compose material_constrained / material_constrained_hashed like material_hashed.
| "enableRender": { | ||
| "description": "Whether Rupy should attempt to use Jinja templating to add context variables into the unit", | ||
| "type": "boolean" | ||
| }, |
Member
There was a problem hiding this comment.
Let's add a "description" field at the top level to explain:
(1) type is necessary field, but these need to be defined as consts/enums in specific "child" instances
(2) replace reference to "Rupy" with "render during workflow/job runtime"
timurbazhirov
approved these changes
Aug 5, 2026
| "$ref": "system/hashed.json" | ||
| } | ||
| ] | ||
| } |
Member
There was a problem hiding this comment.
We can remove scaledHash from top-level material_properties per https://github.com/mat3ra/esse/blob/005522d69e213bec1a94bd3c41172f5539ef9ab7/schema/material/material_properties.json#L42C9-L45C11
Member
There was a problem hiding this comment.
Should we consider:
material_constrained -> material_with_protoproperties
material_hashed -> material_hashed
material_constrained_hashed -> material_with_protoproperties_hashed
Keep MaterialSchema free of hashing fields so MaterialHashed / MaterialConstrainedHashed own scaledHash via the hashed schema. Co-authored-by: Cursor <cursoragent@cursor.com>
Throw when a schema $id is not registered so consumers do not need a local resolve helper. Co-authored-by: Cursor <cursoragent@cursor.com>
Clarify that these variants carry a constrained basis (and optional hash), not a separate "constrained material" domain concept. Co-authored-by: Cursor <cursoragent@cursor.com>
Address review feedback preferring "enhanced" terminology. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Drop null/"" keys before AJV cleaning so entity JSON with optional null fields (e.g. slug) validates, and register tsType/tsEnumNames no-op keywords on shared AJV instances. Co-authored-by: Cursor <cursoragent@cursor.com>
Entity schemas use "" as intentional placeholders (flowchart links); stripping them broke wode condition/subworkflow units. Empty-string cleaning stays in application JsonSchemaValidator. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.