Clarify full-sample fitting under the conformal sharp null - #494
Open
AliFozooni wants to merge 1 commit into
Open
Clarify full-sample fitting under the conformal sharp null#494AliFozooni wants to merge 1 commit into
AliFozooni wants to merge 1 commit into
Conversation
AliFozooni
marked this pull request as ready for review
August 15, 2026 18:09
AliFozooni
force-pushed
the
agent/clarify-conformal-sharp-null-fitting
branch
from
August 15, 2026 18:31
1acb946 to
82af658
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why this matters
Under a candidate sharp null, subtracting the candidate effect imputes the missing untreated outcome in every post-treatment period. The cited procedure then estimates the counterfactual model on that complete candidate path and evaluates the designated post-treatment residual block against cyclic block reassignments. The existing code follows that published algorithm; changing it to fit only before treatment would not be a bug fix, but a different procedure with a fitting-status break at the intervention date.
The p-value is the upper-tail permutation proportion. The formula and implementation already use the correct direction, but the surrounding sentence described the reverse inequality; the text now agrees with both.
Validation
Closes #344