Improve /support and /foundation/members designs - #3534
Conversation
Signed-off-by: MTRNord <MTRNord@users.noreply.github.com>
|
See #3534 (comment) |
Signed-off-by: MTRNord <MTRNord@users.noreply.github.com>
Signed-off-by: MTRNord <MTRNord@users.noreply.github.com>
Deploying matrix-website with
|
| Latest commit: |
3bb1ccc
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ccc7f22f.matrix-website.pages.dev |
| Branch Preview URL: | https://mtrnord-members-support-rede.matrix-website.pages.dev |
then that was probably correct |
Moves .breadcrumb out of _support.scss into _breadcrumb.scss, matching the structure used in other PRs of mine. Signed-off-by: MTRNord <MTRNord@users.noreply.github.com>
| </div> | ||
| <div id="most-popular" class="tier-card"> | ||
| <div id="most-popular" class="tier-card tier-card--group-start tier-card--silver"> | ||
| <p class="tier-card-eyebrow">For organisations</p> |
There was a problem hiding this comment.
but it would need to stay how it currently works or an entirely new solution for the mobile view
There was a problem hiding this comment.
Didnt consider this at all yet.
|
https://github.com/matrix-org/website-wg/issues/17 is also a thing |
There was a problem hiding this comment.
maybe the .step-flow $.colored should use #eee of the current support page rather than #fafafa? the latter is indistinguishable from white to me
|
requesting review from andy to confirm whatever we do here matches the membership contract requirements |
Signed-off-by: MTRNord <MTRNord@users.noreply.github.com>
Signed-off-by: MTRNord <MTRNord@users.noreply.github.com>
Signed-off-by: MTRNord <MTRNord@users.noreply.github.com>
Signed-off-by: MTRNord <MTRNord@users.noreply.github.com>
Signed-off-by: MTRNord <MTRNord@users.noreply.github.com>
Co-authored-by: Kim Brose <2803622+HarHarLinks@users.noreply.github.com> Signed-off-by: Marcel <MTRNord@users.noreply.github.com>
| // membership.html relies on scrollLeft); it was previously | ||
| // overflow-y, which didn't let that horizontal scroll happen at all. | ||
| overflow-x: auto; | ||
| scroll-snap-type: x proximity; |
There was a problem hiding this comment.
on mobile, the initial view on this places the individual members cleanly out of view to the left so the chance to discover it is near 0.
while it could help i'm not sure if snapping to the middle is the solution. it might require some thinking outside the box to solve this properly.
There was a problem hiding this comment.
I added scroll indicators now. I think that solves it.
…croll indicator on the "Become a member" section and improve /support based on comments Signed-off-by: MTRNord <MTRNord@users.noreply.github.com>
Maybe better now?
I flipped it now. Possibly a bit better. I think the title is fine as the first one is somewhat of a CTA and the rest are section headings? |
| let target = document.querySelector(hint.getAttribute('href')); | ||
| if (!target) return; | ||
| e.preventDefault(); | ||
| tiersRow.scrollTo({ left: target.offsetLeft - 16, behavior: 'smooth' }); |
There was a problem hiding this comment.
scroll.mp4
shouldn't this scroll 1 by one instead of to the end?
There was a problem hiding this comment.
hm I guess thats possible too 🤔
| --card-radius: 16px; | ||
| --card-radius-sm: 8px; | ||
|
|
||
| // The top 3 "become a member" tiers are literally named after materials |
There was a problem hiding this comment.
we have reference colors for these and all other tiers at https://github.com/matrix-org/matrix.org/tree/main/static/branding/membership
There was a problem hiding this comment.
That was fixed earlier already. Comment needs fixing/removal though.
There was a problem hiding this comment.
i don't see a green ecosystem members frame nor purple associates
There was a problem hiding this comment.
The buttons should be CTAs = Call To Action. The current proposal does not contain a „call“. They can simple be in the box they belong to 🤷 See the attached screenshot with a sketch. We can think about to find a shorter text for the buttons, or at least for the join as individual button. If you want a bit more variety in the buttons, they can get the tier colour for example.
I also think, that scrolling is really bad, because it hides content. Maybe this can be done for showcases etc. where the content is not important. For the membership I would say it should be a grid that breaks.
Also shouldn't there a link from the support page to the membership page?
| @@ -0,0 +1,249 @@ | |||
| .membership { | |||
There was a problem hiding this comment.
And another huuuge bunch of specific CSS. We should better think more in a framework direction for CTAs, Grids, etc. in my opinion. But we can clean this up later.
|
re: request for my review. The documentation on membership tier benefits, list logo placement perks as: Platinum large logo (front page + sponsor page), Gold medium logo (sponsor page), Silver small logo (sponsor page). (where "sponsor page" is as written in prospectus; we can interpret as members page) So, we must maintain those agreements and arrangements with any improvements. Technically the existing page has both Platinum and Gold tiers with the same sized logos (and neither of the two members have commented on that!), and the revisions proposed do not change those sizes, so from that perspective this seems OK to me. |
if this is indeed the case (or any other updates in that are), somebody (you?) will need to task the WG with it |
|
As I said - I think the update in this PR reflects the current site status 👍🏻 |









Description
More of an experiment trying to align it with all the other changes I proposed. Not sure if it is actually the right direction or not. For sure needs further feedback. I would love a proper masonry layout for example but I seem to not have css support for that :/
Related issues
I guess #2198
Role
Website & Content WG
Timeline
Lets take our time on this one and discuss before thinking about timelines :)
Signoff
Please sign off your individual commits.