scrub-baseline: skip already-redacted Secret markers (#70) - #73
Merged
Merged
Conversation
Baselines rendered by a post-#59 ATLAS already carry REDACTED:sha256: markers; the structural pass re-hashed them into sha256("REDACTED:...") so every Secret showed as changed in review comments — ghost diffs on PRs touching nothing render-relevant. Values already in marker form are now left untouched in both the collection and replacement expressions, making replay over an already-redacted tree a no-op while keeping the leak-closing behavior for pre-redaction baselines. Fixes #70 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
ATLAS ReviewChanges detected in 1 resource(s) across 1 release(s). Affected releasescluster1 / deployment47 / secret-app (1 resources)Secret/secret-app-secret (15 lines)@@ data.generatedCert @@
! ± value change
- REDACTED:sha256:64c2cc8965eb
+ REDACTED:sha256:0531e6a12023
@@ stringData.fromSops @@
! ± value change
- REDACTED:sha256:9dacb914694b
+ REDACTED:sha256:9fab3a1ed1c3
@@ stringData.note @@
! ± value change
- REDACTED:sha256:be359b14f3f4
+ REDACTED:sha256:531854cef641 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the review-pipeline ghost diff from #70: the baseline scrub re-hashed already-present
REDACTED:sha256:markers intosha256("REDACTED:sha256:<hash>"), flagging every Secret as changed on unrelated PRs (verified exactly on the #69 review diff).Marker-form values are now excluded in both the collection and replacement expressions of the structural pass — replay over an already-redacted (post-#59) baseline is a no-op, while pre-redaction baselines still get the full leak-closing scrub. The map replay pass needed no change (it only rewrites exact map-key matches).
Two new tests: marker passthrough (mixed marker/raw Secret) and full run-twice idempotency. Replay suite 11/11.
After merge, the standing
deployment47ghost in self-reviews disappears.🤖 Generated with Claude Code